Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code linting issue where a slice was created non-empty and appended-to #19490

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

mna
Copy link
Member

@mna mna commented Jun 4, 2024

#19290

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (0265554) to head (4b3f325).
Report is 64 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19490       +/-   ##
===========================================
- Coverage   69.81%   63.24%    -6.58%     
===========================================
  Files          15      984      +969     
  Lines         921   120590   +119669     
  Branches       75       75               
===========================================
+ Hits          643    76266    +75623     
- Misses        277    38125    +37848     
- Partials        1     6199     +6198     
Flag Coverage Δ
backend 63.19% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review June 4, 2024 16:23
@mna mna requested a review from a team as a code owner June 4, 2024 16:23
@mna mna merged commit dec9bc5 into main Jun 11, 2024
18 checks passed
@mna mna deleted the mna-19290-fix-make-slice-append branch June 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants