Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitOps & API design: Add multiple Apple Business Manager and Volume Purchasing Program connections #21043
GitOps & API design: Add multiple Apple Business Manager and Volume Purchasing Program connections #21043
Changes from 3 commits
601fddc
1dcc0be
efc85f9
39af40a
65419c6
4e693e3
01286bd
b34628b
42d5dbd
047b86c
bc04aff
bd9b301
2fec90f
88291f6
180387e
c8c768f
124cf80
ce8f43f
c782051
215cf3c
361c12a
37dcf5f
4c56553
1833cca
855ddde
33e0b09
6f5ccb4
50872a1
03bfdb1
3b896b9
c05e170
d6caa89
86ca325
d6c745d
2a2a90d
2936396
37de18e
ff93190
a748baa
ba94f64
9617e26
1d38e18
25f2564
9d21712
8dbd1ab
0e02bb6
282b1f1
eebd60c
d344445
f4e3b91
f50496d
49a3ea0
40c52c1
cadf2db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev
Let's break the existing
GET /vpp
endpoint. It's tagged as experimental: https://github.com/fleetdm/fleet/pull/19291/files#diff-7246bc304b15c8865ed8eaa205e9c244d0a0314e4bae60cf553dc06147c38b64R6395There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note
Maintain support for the old
apple_bm_default_team
. If there's only one ABM token, this value populates themacos_team
for the one ABM team.When the user upgrades, set the new
organization_name.macos_team
to the value for theapple_bm_default_team
.If the user sets
apple_bm_default_team
andorganization_name
at the same time or they setapple_bm_default_team
when there are more than one ABM tokens, return the following error:"mdm.apple_bm_default_team has been deprecated. Please use the new mdm.apple_business_manager key documented here: https://fleetdm.com/learn-more-about/apple-business-manager-gitops"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirect for the URL in the error message is here: https://github.com/fleetdm/fleet/pull/21043/files#diff-0c6120927d3e65309562b5b15b261d3298d05fcb0ff18e5b6512ee683b7ad6b3R533
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note
If the user tries to add a team that doesn't exist, show the following error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA note
The above error will likely happen when a user changes a team's name via GitOps but forgets to update the team name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note
If the user tries to add a team that already has a VPP token, show the following error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @roperzh, now that a new VPP token doesn't have any teams by default (instead of "All team") how do you think the user should specify "All teams" via GitOps?
Could we make it so empty
teams
for a VPP token means it's available for "All teams." And once, the user adds a second VPP token we error and say you have to assign specific teams.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @noahtalerman that makes sense, the only gotcha I see is how would you define "no team"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they would specify
"No team"
which is a special, reserved team name in Fleet.That made me wonder, what happens if I create a team w/ "No team" name in Fleet...
It actually breaks the team. And so does naming a team "All teams." Filed a bug for this here: #21264
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roperzh I think we want to add the reserved "All teams" and "No teams" teams as part of this story.
This way, the IT admin can specify these here in GitOps.
I think let's track this effort as part of the bug: #21264
What do you think?