API design: Self-service: Install Apple App Store apps on macOS #22102
Conversation
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
| - [Batch-apply packages](#batch-apply-packages) | ||
| - [Batch-apply App Store apps](#batch-apply-app-store-apps) | ||
| - [Get token to download package](#get-token-to-download-package) | ||
| - [Download package using a token](#download-package-using-a-token) |
There was a problem hiding this comment.
@lucasmrod when we merged in reference docs for the 4.57 release, it looks like the batch-apply endpoints got moved to the REST API docs instead of the contributors docs (see here).
I moved them back. When you get the chance, can you please check to see if these changes look right?
Also, I moved the download endpoints here b/c I think they're only for the Fleet UI to use (#21341). The best practice download endpoint for the IT admin to use in automations is here: https://fleetdm.com/docs/rest-api/rest-api#download-package
There was a problem hiding this comment.
I'm super confused. It seems we deliberately moved them from API for contributors to REST API? (here).
There was a problem hiding this comment.
Hmm, I see. I think up to @rachaelshaw.
Rachael re your comment here, are we changing our philosophy? That is, endpoints that fleetctl uses (not best practice for automation use cases) live in API for contributors.
There was a problem hiding this comment.
@noahtalerman nope, I was just confused; I saw Luke's review comment about the other /app_store_apps endpoints being the REST API and was like "oh yeah this looks like it fits with those" — I should have double-checked how this endpoint was being used first!
There was a problem hiding this comment.
Got it!
It seems we deliberately moved them from API for contributors to REST API?
@lucasmrod just following up here to say we goofed (which happens). We want the batch-apply endpoints to live in the API for contributors docs.
There was a problem hiding this comment.
@rachaelshaw I think we're ready for final review/merge.
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Error
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Error
rachaelshaw
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
marko-lisica
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
Hey @lukeheath when you get the chance, can you please give this PR a review? Waiting to close the associated user story until this PR is merged. |
API design for:
Old PR: #19687