-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API design: Self-service: Install Apple App Store apps on macOS #22102
Merged
Merged
Changes from 88 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
a8e3242
Update rest-api.md
marko-lisica 622b78a
Update API-for-contributors.md
marko-lisica 7feee4b
Update API-for-contributors.md
marko-lisica 2c81ef9
Update rest-api.md
marko-lisica dfb4b26
Update rest-api.md
marko-lisica 3a276d5
Update rest-api.md
marko-lisica bc25b97
Update rest-api.md
marko-lisica 452406d
Update rest-api.md
marko-lisica c4aeaf0
Update rest-api.md
marko-lisica 6d3a352
Update rest-api.md
marko-lisica deaae54
Update API-for-contributors.md
marko-lisica 81f260a
Update rest-api.md
marko-lisica 575a96c
Update rest-api.md
marko-lisica 6fa5cfb
Update rest-api.md
marko-lisica ea2400b
Update docs/REST API/rest-api.md
marko-lisica 9355615
Update docs/REST API/rest-api.md
marko-lisica be9c5cc
Update docs/REST API/rest-api.md
marko-lisica b41d7a4
Update docs/REST API/rest-api.md
marko-lisica 4e489b5
Update docs/REST API/rest-api.md
marko-lisica 7f6b686
Update docs/REST API/rest-api.md
marko-lisica 1daa447
Update docs/REST API/rest-api.md
marko-lisica d0b980a
Update rest-api.md
marko-lisica 8ebdd6c
Merge branch 'main' into api-design-vpp-apps
marko-lisica 21727ef
Update rest-api.md
marko-lisica 4ca2507
Update rest-api.md
marko-lisica 86f1279
Update rest-api.md
marko-lisica aa90a82
Update docs/REST API/rest-api.md
marko-lisica a83349d
Update docs/REST API/rest-api.md
marko-lisica 79c71ca
Update API-for-contributors.md
marko-lisica 615269c
Update API-for-contributors.md
marko-lisica 505d937
Update docs/REST API/rest-api.md
marko-lisica af962c2
Update docs/REST API/rest-api.md
marko-lisica 2357e05
Merge branch 'main' into api-design-vpp-apps
marko-lisica e42b67b
Merge branch 'main' into api-design-vpp-apps
marko-lisica 0b6a308
Update docs/REST API/rest-api.md
marko-lisica 2603c7d
Update docs/REST API/rest-api.md
marko-lisica 80f9393
Update docs/REST API/rest-api.md
marko-lisica 0935d76
Update docs/REST API/rest-api.md
marko-lisica 38b16f6
Update docs/REST API/rest-api.md
marko-lisica 749f2ff
Update rest-api.md
marko-lisica be4d18e
Update rest-api.md
marko-lisica e7fa7a7
Update docs/REST API/rest-api.md
marko-lisica 4ff4003
Update API-for-contributors.md
marko-lisica 1cb66f3
Update docs/REST API/rest-api.md
marko-lisica 717d0f3
Update docs/REST API/rest-api.md
marko-lisica 0d3ea25
Update docs/REST API/rest-api.md
marko-lisica f5c71a9
Update docs/REST API/rest-api.md
marko-lisica e677dff
Update docs/REST API/rest-api.md
marko-lisica 50a9094
Merge branch 'main' into api-design-vpp-apps
marko-lisica 3dd90e0
Merge branch 'api-design-vpp-apps' into vpp-self-service-api-design
marko-lisica 5f02f0a
Update API-for-contributors.md
marko-lisica ded4054
Update docs/REST API/rest-api.md
marko-lisica bc4c776
Update docs/REST API/rest-api.md
marko-lisica 74ec246
Update docs/REST API/rest-api.md
marko-lisica 025da7e
Update docs/REST API/rest-api.md
marko-lisica d717596
Update rest-api.md
marko-lisica 147e2ac
Merge branch 'api-design-vpp-apps' into vpp-self-service-api-design
marko-lisica 19003af
Update rest-api.md
marko-lisica 007a9d0
Update rest-api.md
marko-lisica f716498
Update rest-api.md
marko-lisica 473f63f
Update API-for-contributors.md
marko-lisica 4c7069f
Update docs/REST API/rest-api.md
marko-lisica 489a38b
Update API-for-contributors.md
marko-lisica b6b9120
Update API-for-contributors.md
marko-lisica 5359a76
Update docs/Contributing/API-for-contributors.md
marko-lisica 5527efd
Update docs/Contributing/API-for-contributors.md
marko-lisica d8f7221
Update docs/Contributing/API-for-contributors.md
marko-lisica 3df87b9
Update docs/Contributing/API-for-contributors.md
marko-lisica e4b46d1
Update docs/Contributing/API-for-contributors.md
marko-lisica c126163
Merge branch 'api-design-vpp-apps' into vpp-self-service-api-design
marko-lisica 6cb3884
Update docs/Contributing/API-for-contributors.md
marko-lisica b01cc87
Update docs/Contributing/API-for-contributors.md
marko-lisica f10d9fb
Update docs/REST API/rest-api.md
marko-lisica 1138d70
Merge branch 'api-design-vpp-apps' into vpp-self-service-api-design
marko-lisica 7b3dd7d
Update rest-api.md
marko-lisica 7472ece
Update rest-api.md
marko-lisica cca0f87
Update API-for-contributors.md
marko-lisica 7a20c2f
Update rest-api.md
marko-lisica 6f6cac3
Merge branch 'api-design-vpp-apps' into vpp-self-service-api-design
marko-lisica f26f6e9
Update API-for-contributors.md
marko-lisica 5b723f1
Merge branch 'main' into vpp-self-service-api-design
marko-lisica a294dee
Update yaml-files.md
marko-lisica d901dcd
Update docs/REST API/rest-api.md
marko-lisica 4490c0c
Update docs/Configuration/yaml-files.md
marko-lisica 8e1e896
Merge branch 'main' into vpp-self-service-api-design
marko-lisica b11414c
Merge in upstream
noahtalerman d32470d
Move endpoints
noahtalerman deb9565
Update docs
noahtalerman d7be5d8
Update docs/Contributing/API-for-contributors.md
rachaelshaw cf5052f
Update docs/Contributing/API-for-contributors.md
rachaelshaw ea0bc2e
Update docs/Contributing/API-for-contributors.md
rachaelshaw b40a950
Merge branch 'main' into vpp-self-service-api-design
marko-lisica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasmrod when we merged in reference docs for the 4.57 release, it looks like the batch-apply endpoints got moved to the REST API docs instead of the contributors docs (see here).
I moved them back. When you get the chance, can you please check to see if these changes look right?
Also, I moved the download endpoints here b/c I think they're only for the Fleet UI to use (#21341). The best practice download endpoint for the IT admin to use in automations is here: https://fleetdm.com/docs/rest-api/rest-api#download-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm super confused. It seems we deliberately moved them from API for contributors to REST API? (here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I see. I think up to @rachaelshaw.
Rachael re your comment here, are we changing our philosophy? That is, endpoints that fleetctl uses (not best practice for automation use cases) live in API for contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahtalerman nope, I was just confused; I saw Luke's review comment about the other
/app_store_apps
endpoints being the REST API and was like "oh yeah this looks like it fits with those" — I should have double-checked how this endpoint was being used first!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
@lucasmrod just following up here to say we goofed (which happens). We want the batch-apply endpoints to live in the API for contributors docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachaelshaw I think we're ready for final review/merge.