Improve MySQL queries that aggregate MDM profile statuses for Apple hosts

[gillespi314]

Issue #22122

• Addresses performance issues seen in deployments with larger-sized host_mdm_apple_profiles and host_mdm_apple_declarations tables (where tables scale based on number of hosts multiplied by number of profiles)
  • Improves performance of MDM profiles summary endpoint
  • Improves performance when filtering hosts by OS settings status (i.e. MDM profiles status)

See areas for future improvement below.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
• Added/updated tests
• Manual QA for all new/changed functionality

[codecov]

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (90c04ee) to head (acee93f).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
server/datastore/mysql/apple_mdm.go	97.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #22252      +/-   ##
==========================================
+ Coverage   65.20%   65.23%   +0.02%     
==========================================
  Files        1495     1495              
  Lines      117110   117187      +77     
  Branches     3512     3512              
==========================================
+ Hits        76365    76449      +84     
+ Misses      33627    33619       -8     
- Partials     7118     7119       +1     

Flag	Coverage Δ
backend	66.53% <97.77%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgekarrv]

LGTM but would love another set of eyes on this.

[roperzh]

#22122

[roperzh]

the query looks scary but it's very nice to read and way better than the old one. LGTM 🎉

[roperzh]

LGTM, seems like an unrelated test failed but I'd be nice to see all tests pass before approving.

could you either remove the new TODO or add parenthesis to the if clause? I think it'll confuse people if we leave it there.

[gillespi314]

Areas for future improvement:

• Disk encryption summary and filters
• Windows profiles summary and filters
• Other places where we're using sub-selects on MDM-related tables?

[gillespi314]

Failing tests are known to be broken/flaky and are not related to this PR.