-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftDialog interface #22321
SwiftDialog interface #22321
Conversation
orbit/pkg/swiftdialog/run.go
Outdated
return s.sendCommand("activate", "") | ||
} | ||
|
||
// Quits dialog with exit code 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: why code 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm! I'd say we should merge this into whatever feature branch we end up making, but that's just my 2¢. only other thing I'd say is some testing, but I'm not sure how we'd do that (maybe look at the contents of the command file? but that doesn't seem super helpful in and of itself) |
Makes sense to me, I'll keep it as a draft then until we're ready to use it 👍 |
The number of flaky tests that just fail without even touching a single line of existing go code is slightly concerning |
SwiftDialog interface for use in orbit. Built for the upcoming out of box experience later this sprint