Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftDialog interface #22321

Merged
merged 23 commits into from
Oct 2, 2024
Merged

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Sep 23, 2024

SwiftDialog interface for use in orbit. Built for the upcoming out of box experience later this sprint

Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>
return s.sendCommand("activate", "")
}

// Quits dialog with exit code 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why code 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahzielv
Copy link
Contributor

overall lgtm! I'd say we should merge this into whatever feature branch we end up making, but that's just my 2¢.

only other thing I'd say is some testing, but I'm not sure how we'd do that (maybe look at the contents of the command file? but that doesn't seem super helpful in and of itself)

@dantecatalfamo
Copy link
Member Author

overall lgtm! I'd say we should merge this into whatever feature branch we end up making, but that's just my 2¢.

only other thing I'd say is some testing, but I'm not sure how we'd do that (maybe look at the contents of the command file? but that doesn't seem super helpful in and of itself)

Makes sense to me, I'll keep it as a draft then until we're ready to use it 👍

@dantecatalfamo dantecatalfamo marked this pull request as draft September 24, 2024 19:15
@dantecatalfamo dantecatalfamo changed the base branch from main to feat-setup-experience September 25, 2024 20:32
@dantecatalfamo dantecatalfamo marked this pull request as ready for review September 26, 2024 13:34
@dantecatalfamo
Copy link
Member Author

The number of flaky tests that just fail without even touching a single line of existing go code is slightly concerning

@dantecatalfamo dantecatalfamo merged commit cf8b3cd into feat-setup-experience Oct 2, 2024
24 of 26 checks passed
@dantecatalfamo dantecatalfamo deleted the swiftdialog-interface branch October 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants