Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset token team assignments to defaults #22326

Merged
merged 11 commits into from
Oct 1, 2024
Merged

fix: reset token team assignments to defaults #22326

merged 11 commits into from
Oct 1, 2024

Conversation

jahzielv
Copy link
Contributor

Related issue: #22198

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.22%. Comparing base (edec764) to head (7029ac9).
Report is 117 commits behind head on main.

Files with missing lines Patch % Lines
server/service/appconfig.go 66.66% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22326      +/-   ##
==========================================
+ Coverage   65.20%   65.22%   +0.01%     
==========================================
  Files        1495     1496       +1     
  Lines      117110   117168      +58     
  Branches     3512     3566      +54     
==========================================
+ Hits        76365    76417      +52     
- Misses      33627    33630       +3     
- Partials     7118     7121       +3     
Flag Coverage Δ
backend 66.49% <66.66%> (-0.01%) ⬇️
frontend 52.35% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dantecatalfamo
dantecatalfamo previously approved these changes Sep 24, 2024
@@ -17,7 +17,7 @@ const generateCell = (teams: ITokenTeam[] | null) => {
}

if (teams.length === 0) {
return <TextCell value="All Teams" />;
return <TextCell value="All teams" />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks

@jahzielv jahzielv merged commit 80f0fd8 into main Oct 1, 2024
27 of 28 checks passed
@jahzielv jahzielv deleted the 22198-defaults branch October 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants