Fix software-with-bundle-ID add when the same title with different/no bundle ID, add missing request timeout special case for edit package endpoint #22413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle ID is provided This avoids "no rows in set" errors when adding software whose name/source matches an existing software title but whose bundle ID doesn't, likely because the bundle ID is null due to e.g. a GitOps upload. There's likely more work to do (e.g. on VPP) for this fallback, and on the write side we should probably be saving bundle identifiers in more places than we're doing (e.g. in the batch endpoint where GitOps is used) but this is the smallest fix that will un-break software uploads.
Missed this in dev. This fixes package uploads on software edit timing out on lower-speed internet connections on larger packages.
…nk to REST API docs
|
@spokanemac You're on here because I missed mentioning an endpoint for timeouts tweaks, so this PR includes a guide update to fix that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22413 +/- ##
==========================================
- Coverage 65.21% 65.21% -0.01%
==========================================
Files 1496 1496
Lines 117157 117169 +12
Branches 3516 3516
==========================================
+ Hits 76408 76409 +1
- Misses 33640 33641 +1
- Partials 7109 7119 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lucasmrod
reviewed
Sep 26, 2024
lucasmrod
reviewed
Sep 26, 2024
lucasmrod
reviewed
Sep 26, 2024
roperzh
reviewed
Sep 26, 2024
spokanemac
previously approved these changes
Sep 26, 2024
iansltx
changed the title
|
Caught this up with the PR into 4.57.1. |
3 tasks
roperzh
approved these changes
Sep 26, 2024
georgekarrv
pushed a commit
that referenced
this pull request
Sep 26, 2024
… bundle ID, add missing request timeout special case for edit package endpoint (#22413) Same as #22412, for #21370, but against `main` rather than 4.57.0. If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Roberto Dip <rroperzh@gmail.com>
georgekarrv
pushed a commit
that referenced
this pull request
Oct 1, 2024
… bundle ID, add missing request timeout special case for edit package endpoint (#22413) Same as #22412, for #21370, but against `main` rather than 4.57.0. If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Roberto Dip <rroperzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #22412, for #21370, but against
mainrather than 4.57.0.Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.