Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix software-with-bundle-ID add when the same title with different/no bundle ID, add missing request timeout special case for edit package endpoint #22413

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Fix software-with-bundle-ID add when the same title with different/no bundle ID, add missing request timeout special case for edit package endpoint #22413

merged 7 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Fall back to name/source for matching software titles on insert if bu… 

    …ndle ID is provided

This avoids "no rows in set" errors when adding software whose name/source matches an existing software title but whose bundle ID doesn't, likely because the bundle ID is null due to e.g. a GitOps upload.

There's likely more work to do (e.g. on VPP) for this fallback, and on the write side we should probably be saving bundle identifiers in more places than we're doing (e.g. in the batch endpoint where GitOps is used) but this is the smallest fix that will un-break software uploads.
    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a47671b View commit details
    Browse the repository at this point in the history

  2. Add changes file

    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e1a55d9 View commit details
    Browse the repository at this point in the history

  3. Use software upload HTTP timeout for software edit endpoint 

    Missed this in dev. This fixes package uploads on software edit timing out on lower-speed internet connections on larger packages.
    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e01e9d2 View commit details
    Browse the repository at this point in the history

  4. Add changes file for timeout fix

    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1973499 View commit details
    Browse the repository at this point in the history

  5. Add missing timeout note on Edit Package endpoint, fix add package li… 

    …nk to REST API docs
    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c6e1558 View commit details
    Browse the repository at this point in the history

  6. fix VPP installers and add tests

    @roperzh @iansltx
    roperzh authored and iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a512821 View commit details
    Browse the repository at this point in the history

  7. Clarify test names, exercise matching code slightly more

    @iansltx
    iansltx committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c1e8eed View commit details
    Browse the repository at this point in the history