Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup live queries #22438

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Cleanup live queries #22438

merged 2 commits into from
Sep 30, 2024

Conversation

mostlikelee
Copy link
Contributor

#22094

Adjusting the cleanup job for expired live queries to delete all expired in batches of maxCount.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (3ca1f5b) to head (1d0ab0d).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/activities.go 55.55% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22438      +/-   ##
==========================================
- Coverage   65.21%   65.19%   -0.03%     
==========================================
  Files        1496     1494       -2     
  Lines      117161   116907     -254     
  Branches     3567     3567              
==========================================
- Hits        76408    76216     -192     
+ Misses      33644    33606      -38     
+ Partials     7109     7085      -24     
Flag Coverage Δ
backend 66.47% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Pending changes file. With a warning that first run of cleanup cron might cause some performance degradation on live queries / scheduled queries until it finishes.

@mostlikelee mostlikelee merged commit ff005d0 into main Sep 30, 2024
21 checks passed
@mostlikelee mostlikelee deleted the 22094-cleanup-queries branch September 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants