Add Fedora built in label #22465
Merged
Add Fedora built in label #22465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
spokanemac
previously approved these changes
Sep 27, 2024
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22465 +/- ##
==========================================
+ Coverage 65.18% 65.20% +0.02%
==========================================
Files 1494 1495 +1
Lines 116865 116940 +75
Branches 3571 3571
==========================================
+ Hits 76173 76249 +76
- Misses 33606 33608 +2
+ Partials 7086 7083 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mostlikelee
force-pushed
the
21409-fedora-label
branch
from
67420d2
to
44848c4
Compare
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
spokanemac
suggested changes
Sep 30, 2024
articles/enroll-hosts.md
Outdated
| @@ -320,7 +320,7 @@ Fleetd will send stdout/stderr logs to the following directories: | |||
|
|
|||
| - macOS: `/private/var/log/orbit/orbit.std{out|err}.log`. | |||
| - Windows: `C:\Windows\system32\config\systemprofile\AppData\Local\FleetDM\Orbit\Logs\orbit-osquery.log` (the log file is rotated). | |||
| - Linux: Orbit and osqueryd stdout/stderr output is sent to syslog (`/var/log/syslog` on Debian systems and `/var/log/messages` on CentOS). | |||
| - Linux: Orbit and osqueryd stdout/stderr output is sent to syslog (`/var/log/syslog` on Debian systems, `/var/log/messages` on CentOS, `journalctl -u orbit` on Fedora). | |||
There was a problem hiding this comment.
, and `journalctl -u orbit` on Fedora
spokanemac
previously approved these changes
Sep 30, 2024
lucasmrod
reviewed
Sep 30, 2024
changes/21409-fedora-label
Outdated
| @@ -0,0 +1 @@ | |||
| - added builtin label for Fedora Linux | |||
There was a problem hiding this comment.
Let's add somewhere that if the users have a label named Fedora Linux, then they need to rename it before running migrations.
There was a problem hiding this comment.
good call! added
lucasmrod
previously approved these changes
Sep 30, 2024
mostlikelee
dismissed stale reviews from lucasmrod and spokanemac
via
5e5a0da
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
lucasmrod
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21409
Add Fedora built in label
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).