Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Add support for .rpm packages #22469

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Sep 27, 2024

Issue

FE of #20537

Description

  • Add support for .rpm packages in UI
  • Update unit test accordingly

Note

#21810 part of #18865 will be moving the parent component around. Test/rebase onto that work when ready.

Screenshot

Screenshot 2024-09-27 at 8 49 57 AM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (705cdd0) to head (b062290).
Report is 1 commits behind head on 20537-add-rpm-support.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           20537-add-rpm-support   #22469   +/-   ##
======================================================
  Coverage                  65.22%   65.22%           
======================================================
  Files                       1495     1495           
  Lines                     116924   116924           
  Branches                    3567     3577   +10     
======================================================
  Hits                       76264    76264           
  Misses                     33580    33580           
  Partials                    7080     7080           
Flag Coverage Δ
frontend 52.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia marked this pull request as ready for review September 30, 2024 14:01
@RachelElysia RachelElysia merged commit c12464b into 20537-add-rpm-support Sep 30, 2024
11 checks passed
@RachelElysia RachelElysia deleted the 20537-rpm-fe branch September 30, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants