Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle query query param for the fleet maintained apps list endpoint #22501

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Sep 30, 2024

support the query query param for the GET /fleet_maintained_apps endpoint

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-fleet-app-library@35b4f20). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/maintained_apps.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             feat-fleet-app-library   #22501   +/-   ##
=========================================================
  Coverage                          ?   65.24%           
=========================================================
  Files                             ?     1502           
  Lines                             ?   117350           
  Branches                          ?     3564           
=========================================================
  Hits                              ?    76564           
  Misses                            ?    33671           
  Partials                          ?     7115           
Flag Coverage Δ
backend 66.51% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghernandez345 ghernandez345 force-pushed the chore-api-add-query-filter-for-fleet-maintained-endpoint branch from 40ab5d8 to e141764 Compare September 30, 2024 16:19
@ghernandez345 ghernandez345 merged commit 3e175d0 into feat-fleet-app-library Sep 30, 2024
18 checks passed
@ghernandez345 ghernandez345 deleted the chore-api-add-query-filter-for-fleet-maintained-endpoint branch September 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants