Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to upload RPM packages #22502

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Add support to upload RPM packages #22502

merged 4 commits into from
Oct 1, 2024

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Sep 30, 2024

#22473

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.10%. Comparing base (59160c2) to head (26c9f17).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
pkg/file/rpm.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22502      +/-   ##
==========================================
- Coverage   65.20%   65.10%   -0.10%     
==========================================
  Files        1494     1496       +2     
  Lines      116898   116977      +79     
  Branches     3578     3568      -10     
==========================================
- Hits        76218    76158      -60     
- Misses      33599    33733     +134     
- Partials     7081     7086       +5     
Flag Coverage Δ
backend 66.37% <87.50%> (-0.11%) ⬇️
frontend 52.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia
Copy link
Member

PR #22469 into this branch before merging to main will fix FE test and entire feature will be ready on this branch

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM. For backend, only question I have is around the (un)install scripts we're using, otherwise LGTM.

pkg/file/scripts/install_rpm.sh Show resolved Hide resolved
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that we're good to use dnf for install scripts, so :shipit:

@lucasmrod lucasmrod merged commit f8f24e0 into main Oct 1, 2024
38 checks passed
@lucasmrod lucasmrod deleted the 20537-add-rpm-support branch October 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants