-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to upload RPM packages #22502
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22502 +/- ##
==========================================
- Coverage 65.20% 65.10% -0.10%
==========================================
Files 1494 1496 +2
Lines 116898 116977 +79
Branches 3578 3568 -10
==========================================
- Hits 76218 76158 -60
- Misses 33599 33733 +134
- Partials 7081 7086 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR #22469 into this branch before merging to main will fix FE test and entire feature will be ready on this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend LGTM. For backend, only question I have is around the (un)install scripts we're using, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that we're good to use dnf
for install scripts, so
#22473
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.