Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sandbox backend tests #22510

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Remove sandbox backend tests #22510

merged 1 commit into from
Sep 30, 2024

Conversation

lucasmrod
Copy link
Member

Removing some Sandbox tests and some old proposals that are not valid anymore.

(As agreed in weekly backend.)

@mostlikelee
Copy link
Contributor

In case sandbox comes back in the future, is it as simple as reverting this commit?

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (98c0bd8) to head (b1fd8d7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22510      +/-   ##
==========================================
- Coverage   65.22%   65.09%   -0.14%     
==========================================
  Files        1495     1495              
  Lines      116940   116940              
  Branches     3578     3578              
==========================================
- Hits        76279    76126     -153     
- Misses      33581    33731     +150     
- Partials     7080     7083       +3     
Flag Coverage Δ
backend 66.36% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasmrod
Copy link
Member Author

In case sandbox comes back in the future, is it as simple as reverting this commit?

If it comes back it may be in a different form?, but yes, reverting the commit should work.

@lucasmrod
Copy link
Member Author

Failing test is a flaky test and codecov seems was successful but is stuck on the codecov side.

@lucasmrod lucasmrod merged commit b1ee052 into main Sep 30, 2024
24 of 27 checks passed
@lucasmrod lucasmrod deleted the remove-sandbox-backend-tests branch September 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants