Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDES SCEP proxy backend #22542

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

NDES SCEP proxy backend #22542

wants to merge 10 commits into from

Conversation

getvictor
Copy link
Member

#21955

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 23.78049% with 125 lines in your changes missing coverage. Please review.

Project coverage is 55.59%. Comparing base (cfd4159) to head (feeb5b2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/mdm/scep/server/transport.go 0.00% 34 Missing ⚠️
ee/server/service/scep_proxy.go 48.07% 24 Missing and 3 partials ⚠️
server/mdm/scep/server/endpoint.go 0.00% 19 Missing ⚠️
server/service/appconfig.go 9.52% 18 Missing and 1 partial ⚠️
server/service/handler.go 0.00% 12 Missing ⚠️
server/datastore/mysql/app_configs.go 52.17% 10 Missing and 1 partial ⚠️
cmd/fleet/serve.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22542      +/-   ##
==========================================
- Coverage   65.10%   55.59%   -9.51%     
==========================================
  Files        1496     1497       +1     
  Lines      117001   117188     +187     
  Branches     3571     3571              
==========================================
- Hits        76169    65150   -11019     
- Misses      33744    45797   +12053     
+ Partials     7088     6241     -847     
Flag Coverage Δ
backend 55.80% <23.78%> (-10.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant