Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align battery health reporting #22569

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Align battery health reporting #22569

merged 6 commits into from
Oct 2, 2024

Conversation

mostlikelee
Copy link
Contributor

@mostlikelee mostlikelee commented Oct 2, 2024

#22554 Unreleased Bug

Aligning the definition of battery health between macOS and Windows to be Normal unless:

  • cycle_count >= 1000
    OR

  • max_capacity / designed_capacity is 80% or above

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Added/updated tests

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (8977594) to head (05b517a).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
server/service/osquery_utils/queries.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22569      +/-   ##
==========================================
- Coverage   65.11%   65.09%   -0.02%     
==========================================
  Files        1497     1498       +1     
  Lines      117063   117134      +71     
  Branches     3578     3578              
==========================================
+ Hits        76222    76249      +27     
- Misses      33750    33795      +45     
+ Partials     7091     7090       -1     
Flag Coverage Δ
backend 66.35% <95.65%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mostlikelee mostlikelee marked this pull request as ready for review October 2, 2024 16:19
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also definitely needs a changes file as this will change how hosts report battery.

For the query removal, are we able just push that because the mac/win battery query split isn't released yet? Or are there BC concerns?

server/service/osquery_utils/queries.go Show resolved Hide resolved
server/service/osquery_utils/queries.go Show resolved Hide resolved
server/service/osquery_utils/queries.go Show resolved Hide resolved
server/service/osquery_utils/queries.go Show resolved Hide resolved
@lukeheath
Copy link
Member

@mostlikelee Let me know when this is ready and I'll provide approval for the contributing docs if needed.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixed an "it's" that should've been an "its" so we're good to go.

@mostlikelee
Copy link
Contributor Author

@lukeheath PR is ready for a docs review

@mostlikelee mostlikelee merged commit 46ade66 into main Oct 2, 2024
18 checks passed
@mostlikelee mostlikelee deleted the 22554-battery-reporting branch October 2, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants