-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align battery health reporting #22569
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22569 +/- ##
==========================================
- Coverage 65.11% 65.09% -0.02%
==========================================
Files 1497 1498 +1
Lines 117063 117134 +71
Branches 3578 3578
==========================================
+ Hits 76222 76249 +27
- Misses 33750 33795 +45
+ Partials 7091 7090 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also definitely needs a changes file as this will change how hosts report battery.
For the query removal, are we able just push that because the mac/win battery query split isn't released yet? Or are there BC concerns?
@mostlikelee Let me know when this is ready and I'll provide approval for the contributing docs if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixed an "it's" that should've been an "its" so we're good to go.
@lukeheath PR is ready for a docs review |
#22554 Unreleased Bug
Aligning the definition of battery health between macOS and Windows to be
Normal
unless:cycle_count
>= 1000OR
max_capacity / designed_capacity
is 80% or aboveChanges file added for user-visible changes in
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
Added/updated tests
Manual QA for all new/changed functionality