FMA: missing pieces

[roperzh]

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
• Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
• Added/updated tests
• If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
• If database migrations are included, checked table schema to confirm autoupdate
• For database migrations:
  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
• Manual QA for all new/changed functionality
• For Orbit and Fleet Desktop changes:
  • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
  • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
  • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

[codecov]

Codecov Report

Attention: Patch coverage is 78.85463% with 48 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-fleet-app-library@3727474). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
server/mdm/maintainedapps/scripts.go	79.89%	34 Missing and 5 partials ⚠️
ee/server/service/maintained_apps.go	69.23%	2 Missing and 2 partials ⚠️
ee/server/service/software_installers.go	33.33%	2 Missing ⚠️
server/mdm/maintainedapps/ingest.go	50.00%	1 Missing and 1 partial ⚠️
server/service/maintained_apps.go	90.90%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##             feat-fleet-app-library   #22593   +/-   ##
=========================================================
  Coverage                          ?   65.15%           
=========================================================
  Files                             ?     1518           
  Lines                             ?   117804           
  Branches                          ?     3532           
=========================================================
  Hits                              ?    76761           
  Misses                            ?    33913           
  Partials                          ?     7130           

Flag	Coverage Δ
backend	66.44% <78.85%> (?)
frontend	52.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gillespi314]

Very nice!

[gillespi314]

Neato!

[jahzielv]

backend lgtm ✨