Use pkgutil approach to be more effective at uninstalling
#22618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
changed the title
pkgutil approach to be more effective at uninstalling
lucasmrod
commented
Oct 3, 2024
| location=$(pkgutil --pkg-info "$pkg_id" | grep -i "location" | awk '{if (NF>1) print $NF}') | ||
| # Check if this package id corresponds to a valid/installed package | ||
| if [[ ! -z "$volume" ]]; then |
There was a problem hiding this comment.
Only checking for empty volume now (e.g. fleetd has location empty)
lucasmrod
commented
Oct 3, 2024
Comment on lines
+10
to
+11
| location=$(pkgutil --pkg-info "$pkg_id" | grep -i "location" | awk '{if (NF>1) print $NF}') |
There was a problem hiding this comment.
Using what @getvictor proposed.
getvictor
approved these changes
Oct 3, 2024
| @@ -15,7 +15,7 @@ import ( | |||
|
|
|||
| func TestPreProcessUninstallScript(t *testing.T) { | |||
| t.Parallel() | |||
| input := ` | |||
| var input = ` | |||
There was a problem hiding this comment.
gofmt in reverse commit mode :) ...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22618 +/- ##
=======================================
Coverage 65.07% 65.08%
=======================================
Files 1498 1498
Lines 117134 117138 +4
Branches 3519 3519
=======================================
+ Hits 76228 76242 +14
+ Misses 33810 33804 -6
+ Partials 7096 7092 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
CI failure is just a flaky test failing. Merging. |
lucasmrod
added a commit
that referenced
this pull request
Oct 3, 2024
#22571 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Added/updated tests - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [X] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Manual QA for all new/changed functionality
This was referenced Oct 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22571
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
COLLATE utf8mb4_unicode_ci).