Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zenity package #23619

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add zenity package #23619

wants to merge 18 commits into from

Conversation

mostlikelee
Copy link
Contributor

@mostlikelee mostlikelee commented Nov 7, 2024

#23585

Adding package for zenity command on Linux to be used in #23586 and will be manually tested in that task.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 37.19512% with 103 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (8a8b840) to head (300b04d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/execuser/execuser_linux.go 0.00% 69 Missing ⚠️
orbit/pkg/zenity/zenity.go 73.49% 22 Missing ⚠️
orbit/pkg/execuser/execuser.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23619      +/-   ##
==========================================
- Coverage   63.20%   63.16%   -0.05%     
==========================================
  Files        1563     1564       +1     
  Lines      148874   149022     +148     
  Branches     3700     3700              
==========================================
+ Hits        94103    94135      +32     
- Misses      47351    47463     +112     
- Partials     7420     7424       +4     
Flag Coverage Δ
backend 64.01% <37.19%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review pass done, left some comments!

zayhanlon
zayhanlon previously approved these changes Nov 11, 2024
@mostlikelee mostlikelee removed request for getvictor, a team and eashaw November 14, 2024 16:30
@mostlikelee mostlikelee marked this pull request as draft November 19, 2024 18:20
@mostlikelee mostlikelee changed the base branch from 22074-linux-encryption to main November 19, 2024 20:55
@mostlikelee mostlikelee dismissed zayhanlon’s stale review November 19, 2024 20:55

The base branch was changed.

@mostlikelee mostlikelee marked this pull request as ready for review November 19, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants