Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #23857 into RC v4.60.0 #23867

Merged

Conversation

lucasmrod
Copy link
Member

Cherry pick PR #23857 into RC v4.60.0.

@lucasmrod lucasmrod requested review from a team as code owners November 15, 2024 20:58
@lucasmrod lucasmrod changed the base branch from main to rc-minor-fleet-v4.60.0 November 15, 2024 20:59
We will ship 4.59.1 with the
20241110152839_AddTeamIdentifierToHostSoftwareInstalledPaths.go
migration, thus I'm moving the unreleased ones to "execute later".
@lucasmrod lucasmrod force-pushed the cherry-pick-23857-into-rc-minor-fleet-v4.60.0 branch from 2a55ab4 to 5a6fddc Compare November 15, 2024 23:13
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.60.0@b805d95). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rations/tables/20241110152840_AddYaraRulesTable.go 66.66% 1 Missing ⚠️
...s/20241110152841_AddAllLabelsToMDMProfileLabels.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.60.0   #23867   +/-   ##
=========================================================
  Coverage                          ?   63.15%           
=========================================================
  Files                             ?     1560           
  Lines                             ?   148327           
  Branches                          ?     3720           
=========================================================
  Hits                              ?    93682           
  Misses                            ?    47244           
  Partials                          ?     7401           
Flag Coverage Δ
backend 63.99% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx
Copy link
Member

iansltx commented Nov 15, 2024

Merging this now to avoid cherry-pick stacking issues.

@iansltx iansltx merged commit db35c39 into rc-minor-fleet-v4.60.0 Nov 15, 2024
18 checks passed
@iansltx iansltx deleted the cherry-pick-23857-into-rc-minor-fleet-v4.60.0 branch November 15, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants