Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing instrumentation for APM. #23882

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

getvictor
Copy link
Member

#19696

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (c93a28b) to head (7916c0d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleet/serve.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23882   +/-   ##
=======================================
  Coverage   63.16%   63.16%           
=======================================
  Files        1560     1560           
  Lines      148412   148416    +4     
  Branches     3729     3729           
=======================================
+ Hits        93745    93754    +9     
+ Misses      47265    47262    -3     
+ Partials     7402     7400    -2     
Flag Coverage Δ
backend 64.01% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@getvictor getvictor marked this pull request as ready for review November 16, 2024 00:22
@getvictor getvictor requested a review from a team as a code owner November 16, 2024 00:22
@getvictor
Copy link
Member Author

@mna Please review

Copy link
Member

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I assume you did see the previously-uninstrumented endpoints in APM in your manual QA.

@getvictor getvictor merged commit 06d233a into main Nov 18, 2024
22 checks passed
@getvictor getvictor deleted the victor/19696-instrument-apm branch November 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants