Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nanomdm dependency with latest bug fixes and improvements. #23906

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Nov 18, 2024

#23905

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 49.41084% with 644 lines in your changes missing coverage. Please review.

Project coverage is 63.48%. Comparing base (1112774) to head (34be418).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
server/mdm/nanomdm/test/enrollment/enrollment.go 73.00% 42 Missing and 19 partials ⚠️
server/mdm/nanomdm/push/nanopush/nanopush.go 0.00% 52 Missing ⚠️
server/mdm/nanomdm/http/mdm/mdm_cert.go 39.47% 40 Missing and 6 partials ⚠️
server/mdm/nanomdm/cmd/nanomdm/main.go 0.00% 45 Missing ⚠️
server/mdm/nanomdm/http/authproxy/authproxy.go 0.00% 45 Missing ⚠️
server/mdm/nanomdm/push/nanopush/provider.go 61.00% 31 Missing and 8 partials ⚠️
server/mdm/nanomdm/test/enrollment/utils.go 5.88% 30 Missing and 2 partials ⚠️
server/mdm/nanomdm/test/e2e/certauth.go 62.65% 21 Missing and 10 partials ⚠️
server/mdm/nanomdm/test/protocol/transport.go 62.50% 20 Missing and 10 partials ⚠️
server/mdm/nanomdm/http/api/api.go 0.00% 17 Missing and 4 partials ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23906      +/-   ##
==========================================
+ Coverage   63.16%   63.48%   +0.32%     
==========================================
  Files        1560     1570      +10     
  Lines      148420   149176     +756     
  Branches     3729     3729              
==========================================
+ Hits        93747    94703     +956     
+ Misses      47268    46913     -355     
- Partials     7405     7560     +155     
Flag Coverage Δ
backend 64.35% <49.41%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants