Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing Opera PE self-extracting archive. (#23751) #23927

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

getvictor
Copy link
Member

#23540

(cherry picked from commit 687ce3a)

#23540

Tested installers from Google drive:
https://drive.google.com/drive/folders/1MZVwgZu5Af7JnSnKCFknRPGDXM29mOa6

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
(cherry picked from commit 687ce3a)
@getvictor getvictor merged commit 42f7599 into rc-minor-fleet-v4.60.0 Nov 18, 2024
17 checks passed
@getvictor getvictor deleted the victor/23540-cherry-pick branch November 18, 2024 22:31
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.60.0@2ca7b28). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/file/pe.go 48.38% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.60.0   #23927   +/-   ##
=========================================================
  Coverage                          ?   63.17%           
=========================================================
  Files                             ?     1560           
  Lines                             ?   148418           
  Branches                          ?     3719           
=========================================================
  Hits                              ?    93756           
  Misses                            ?    47257           
  Partials                          ?     7405           
Flag Coverage Δ
backend 64.00% <48.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants