Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to merge dev into master #32

Merged
merged 122 commits into from
Nov 17, 2023
Merged

Request to merge dev into master #32

merged 122 commits into from
Nov 17, 2023

Conversation

flemton
Copy link
Owner

@flemton flemton commented Nov 17, 2023

Dear reviewer, below are the pull requests we merged to complete the project requirements, our team consisted of two developers (@flemton and @JuanDiegoGuerra ) working together with different ideas and merge conflicts but we emerged victorious against those merge conflicts 😄 , here are the PRs and commits that made the project a success:

Merge pull request #20 from flemton/feature/setup

Merge pull request #21 from flemton/feature/setup-models-and-database

Merge pull request #22 from flemton/feature/add-devise

Merge pull request #23 from flemton/setup_quick_fixes

Merge pull request #24 from flemton/views_controllers

Merge pull request #25 from flemton/food_recipe_list

Merge pull request #26 from flemton/recipe_details_page

Merge pull request #27 from flemton/public_recipes_pages-general_shop…

Merge pull request #28 from flemton/add-devise_and_cancancan

Merge pull request #30 from flemton/feature/READme

Merge pull request #31 from flemton/feature/setup-linters

Any requested changes are welcome, also, specific commits can be found in each PR, cheers 🥂

@JuanDiegoGuerra JuanDiegoGuerra added the mvp MVP Ready for Deployment label Nov 17, 2023
Copy link

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flemton @JuanDiegoGuerra 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Well-written PR 👍
  • No linter errors 👍
  • N+1 issue solved 👍
  • All tests passed 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@flemton flemton merged commit 20cc74a into master Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mvp MVP Ready for Deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants