POL-1398 Azure Expiring Credentials - fix Days Until Expiration bug (#…

…2772)

* change on line 351 to correct calculation on days until expiration

* update changelog with changes made

* Update Meta Parent Policy Templates (#2773)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* update policy permissions list

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

data/policy_permissions_list/master_policy_permissions_list.json

@@ -6516,7 +6516,7 @@
     {
       "id": "./operational/azure/azure_certificates/azure_certificates.pt",
       "name": "Azure Expiring Certificates",
-      "version": "4.0.0",
+      "version": "4.0.1",
       "providers": [
         {
           "name": "azure_rm",

data/policy_permissions_list/master_policy_permissions_list.yaml

@@ -3780,7 +3780,7 @@
       required: true
 - id: "./operational/azure/azure_certificates/azure_certificates.pt"
   name: Azure Expiring Certificates
-  version: 4.0.0
+  version: 4.0.1
   :providers:
   - :name: azure_rm
     :permissions:

operational/azure/azure_certificates/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v4.0.1
+
+- Fixed issue where policy incident would show incorrect `Days Until Expiration` for several resources
+
 ## v4.0.0
 
 - Added ability to delete Azure certificates automatically or manually

operational/azure/azure_certificates/azure_certificates.pt

@@ -7,7 +7,7 @@ category "Operational"
 severity "low"
 default_frequency "daily"
 info(
-  version: "4.0.0",
+  version: "4.0.1",
   provider: "Azure",
   service: "PaaS",
   policy_set: "Expiring Certificates"
@@ -348,7 +348,7 @@ script "js_azure_certificates_expiring", type: "javascript" do
     if (today >= expiration_date) {
       status = "Expired"
     } else {
-      days_until_expiration = Math.round((today - expiration_date) / 86400000)
+      days_until_expiration = Math.round((expiration_date - today) / 86400000)
     }
 
     if (status == "Expired" || days_until_expiration <= param_expiration_days) {

operational/azure/azure_certificates/azure_certificates_meta_parent.pt

@@ -7,7 +7,7 @@ category "Meta"
 default_frequency "15 minutes"
 info(
   provider: "Azure",
-  version: "4.0.0", # This version of the Meta Parent Policy Template should match the version of the Child Policy Template as it appears in the Catalog for best reliability
+  version: "4.0.1", # This version of the Meta Parent Policy Template should match the version of the Child Policy Template as it appears in the Catalog for best reliability
   publish: "true",
   deprecated: "false"
 )