POL-1378 Linting Updates: SaaS Policies (#2733)

* update * fix * update * fix * update * fix * update * update * update * update * update * update * update * update * update
flexera-public · Oct 14, 2024 · 7f78228 · 7f78228
1 parent 0c3cb3a
commit 7f78228
Show file tree

Hide file tree

Showing 35 changed files with 85 additions and 44 deletions.
diff --git a/data/policy_permissions_list/master_policy_permissions_list.json b/data/policy_permissions_list/master_policy_permissions_list.json
@@ -6981,7 +6981,7 @@
     {
       "id": "./saas/fsm/deactivated_users/deactivated_users.pt",
       "name": "SaaS Manager - Deactivated Users",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -6998,7 +6998,7 @@
     {
       "id": "./saas/fsm/deactivated_users_for_integrated_apps/deactivated_users_for_integrated_apps.pt",
       "name": "SaaS Manager - Deactivated Users for Integrated Applications",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -7015,7 +7015,7 @@
     {
       "id": "./saas/fsm/duplicate_users/duplicate_users.pt",
       "name": "SaaS Manager - Duplicate User Accounts",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -7032,7 +7032,7 @@
     {
       "id": "./saas/fsm/redundant_apps/fsm-redundant_apps.pt",
       "name": "SaaS Manager - Redundant Apps",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -7049,7 +7049,7 @@
     {
       "id": "./saas/fsm/renewal_reminder/fsm-renewal_reminder.pt",
       "name": "SaaS Manager - Renewal Reminder",
-      "version": "3.2",
+      "version": "3.2.1",
       "providers": [
         {
           "name": "flexera",
@@ -7066,7 +7066,7 @@
     {
       "id": "./saas/fsm/suspicious_users/fsm-suspicious_users.pt",
       "name": "SaaS Manager - Suspicious Users",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -7083,7 +7083,7 @@
     {
       "id": "./saas/fsm/unsanctioned_apps_with_contract/fsm-unsanctioned_with_contract.pt",
       "name": "SaaS Manager - Unsanctioned Applications with Existing Contract",
-      "version": "3.2",
+      "version": "3.2.1",
       "providers": [
         {
           "name": "flexera",
@@ -7100,7 +7100,7 @@
     {
       "id": "./saas/fsm/unsanctioned_spend/fsm-unsanctioned_spend.pt",
       "name": "SaaS Manager - Unsanctioned Spend",
-      "version": "3.1",
+      "version": "3.1.1",
       "providers": [
         {
           "name": "flexera",
@@ -7117,7 +7117,7 @@
     {
       "id": "./saas/fsm/users_by_category/users_by_category.pt",
       "name": "SaaS Manager - SaaS App User Report by Category",
-      "version": "3.0.0",
+      "version": "3.0.1",
       "providers": [
         {
           "name": "flexera",

diff --git a/data/policy_permissions_list/master_policy_permissions_list.yaml b/data/policy_permissions_list/master_policy_permissions_list.yaml
@@ -4051,7 +4051,7 @@
       required: true
 - id: "./saas/fsm/deactivated_users/deactivated_users.pt"
   name: SaaS Manager - Deactivated Users
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4060,7 +4060,7 @@
       required: true
 - id: "./saas/fsm/deactivated_users_for_integrated_apps/deactivated_users_for_integrated_apps.pt"
   name: SaaS Manager - Deactivated Users for Integrated Applications
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4069,7 +4069,7 @@
       required: true
 - id: "./saas/fsm/duplicate_users/duplicate_users.pt"
   name: SaaS Manager - Duplicate User Accounts
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4078,7 +4078,7 @@
       required: true
 - id: "./saas/fsm/redundant_apps/fsm-redundant_apps.pt"
   name: SaaS Manager - Redundant Apps
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4087,7 +4087,7 @@
       required: true
 - id: "./saas/fsm/renewal_reminder/fsm-renewal_reminder.pt"
   name: SaaS Manager - Renewal Reminder
-  version: '3.2'
+  version: 3.2.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4096,7 +4096,7 @@
       required: true
 - id: "./saas/fsm/suspicious_users/fsm-suspicious_users.pt"
   name: SaaS Manager - Suspicious Users
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4105,7 +4105,7 @@
       required: true
 - id: "./saas/fsm/unsanctioned_apps_with_contract/fsm-unsanctioned_with_contract.pt"
   name: SaaS Manager - Unsanctioned Applications with Existing Contract
-  version: '3.2'
+  version: 3.2.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4114,7 +4114,7 @@
       required: true
 - id: "./saas/fsm/unsanctioned_spend/fsm-unsanctioned_spend.pt"
   name: SaaS Manager - Unsanctioned Spend
-  version: '3.1'
+  version: 3.1.1
   :providers:
   - :name: flexera
     :permissions:
@@ -4123,7 +4123,7 @@
       required: true
 - id: "./saas/fsm/users_by_category/users_by_category.pt"
   name: SaaS Manager - SaaS App User Report by Category
-  version: 3.0.0
+  version: 3.0.1
   :providers:
   - :name: flexera
     :permissions:

diff --git a/saas/fsm/deactivated_users/CHANGELOG.md b/saas/fsm/deactivated_users/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/deactivated_users/README.md b/saas/fsm/deactivated_users/README.md
@@ -39,4 +39,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/deactivated_users/deactivated_users.pt b/saas/fsm/deactivated_users/deactivated_users.pt
@@ -7,7 +7,7 @@ severity "medium"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/deactivated_users_for_integrated_apps/CHANGELOG.md b/saas/fsm/deactivated_users_for_integrated_apps/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/deactivated_users_for_integrated_apps/README.md b/saas/fsm/deactivated_users_for_integrated_apps/README.md
@@ -39,4 +39,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/deactivated_users_for_integrated_apps/deactivated_users_for_integrated_apps.pt b/saas/fsm/deactivated_users_for_integrated_apps/deactivated_users_for_integrated_apps.pt
@@ -7,7 +7,7 @@ severity "medium"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/duplicate_users/CHANGELOG.md b/saas/fsm/duplicate_users/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/duplicate_users/README.md b/saas/fsm/duplicate_users/README.md
@@ -37,4 +37,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/duplicate_users/duplicate_users.pt b/saas/fsm/duplicate_users/duplicate_users.pt
@@ -7,7 +7,7 @@ severity "medium"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/redundant_apps/CHANGELOG.md b/saas/fsm/redundant_apps/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/redundant_apps/README.md b/saas/fsm/redundant_apps/README.md
@@ -38,4 +38,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/redundant_apps/fsm-redundant_apps.pt b/saas/fsm/redundant_apps/fsm-redundant_apps.pt
@@ -7,7 +7,7 @@ severity "low"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""
@@ -31,6 +31,7 @@ parameter "param_too_many_apps" do
   label "Category Application Limit"
   description "The number of SaaS applications within a single category required to report on the category."
   min_value 2
+  default 2
 end
 
 ###############################################################################

diff --git a/saas/fsm/renewal_reminder/CHANGELOG.md b/saas/fsm/renewal_reminder/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.2.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.2
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/renewal_reminder/README.md b/saas/fsm/renewal_reminder/README.md
@@ -39,4 +39,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/renewal_reminder/fsm-renewal_reminder.pt b/saas/fsm/renewal_reminder/fsm-renewal_reminder.pt
@@ -7,7 +7,7 @@ severity "medium"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.2",
+  version: "3.2.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/suspicious_users/CHANGELOG.md b/saas/fsm/suspicious_users/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/suspicious_users/README.md b/saas/fsm/suspicious_users/README.md
@@ -40,4 +40,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/suspicious_users/fsm-suspicious_users.pt b/saas/fsm/suspicious_users/fsm-suspicious_users.pt
@@ -7,7 +7,7 @@ severity "high"
 default_frequency "weekly"
 category "SaaS Management"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/unsanctioned_apps_with_contract/CHANGELOG.md b/saas/fsm/unsanctioned_apps_with_contract/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.2.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.2
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/unsanctioned_apps_with_contract/README.md b/saas/fsm/unsanctioned_apps_with_contract/README.md
@@ -40,4 +40,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/unsanctioned_apps_with_contract/fsm-unsanctioned_with_contract.pt b/saas/fsm/unsanctioned_apps_with_contract/fsm-unsanctioned_with_contract.pt
@@ -7,7 +7,7 @@ severity "high"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.2",
+  version: "3.2.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""

diff --git a/saas/fsm/unsanctioned_spend/CHANGELOG.md b/saas/fsm/unsanctioned_spend/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v3.1.1
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v3.1
 
 - Policy updated so that policy is correctly identified as a Flexera policy

diff --git a/saas/fsm/unsanctioned_spend/README.md b/saas/fsm/unsanctioned_spend/README.md
@@ -42,4 +42,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.
diff --git a/saas/fsm/unsanctioned_spend/fsm-unsanctioned_spend.pt b/saas/fsm/unsanctioned_spend/fsm-unsanctioned_spend.pt
@@ -7,7 +7,7 @@ severity "medium"
 category "SaaS Management"
 default_frequency "weekly"
 info(
-  version: "3.1",
+  version: "3.1.1",
   provider: "Flexera",
   service: "SaaS Manager",
   policy_set: ""
@@ -30,6 +30,7 @@ parameter "param_unsanctioned_apps" do
   category "Policy Settings"
   label "Unsanctioned Application Names"
   description "List of SaaS Application names that the policy will target for identifying unsanctioned spend. Note: if left blank, the policy will detect all unsanctioned spend."
+  # No default value, user input required
 end
 
 parameter "param_days" do

diff --git a/saas/fsm/user_status_change/CHANGELOG.md b/saas/fsm/user_status_change/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.8.3
+
+- Minor code improvements to conform with current standards. Functionality unchanged.
+
 ## v2.8.2
 
 - Policy is no longer published to the Flexera catalog.

diff --git a/saas/fsm/user_status_change/README.md b/saas/fsm/user_status_change/README.md
@@ -45,4 +45,4 @@ The [Provider-Specific Credentials](https://docs.flexera.com/flexera/EN/Automati
 
 ## Cost
 
-This Policy Template does not incur any cloud costs.
+This policy template does not incur any cloud costs.