Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-918 Create Master Policy Permissions List #1674

Merged
merged 98 commits into from
Feb 12, 2024

Conversation

nia-vf1
Copy link
Contributor

@nia-vf1 nia-vf1 commented Dec 7, 2023

Description

Issues Resolved

Link to Example Applied Policy

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

@nia-vf1 nia-vf1 self-assigned this Dec 7, 2023
@nia-vf1 nia-vf1 requested a review from a team as a code owner December 7, 2023 15:27
nia-vf1 and others added 19 commits December 7, 2023 15:30
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
Co-authored-by: XOmniverse <XOmniverse@users.noreply.github.com>
…tes into POL-918-create-master-policy-perm-list
…nal:flexera-public/policy_templates into POL-918-create-master-policy-perm-list
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
…nal:flexera-public/policy_templates into POL-918-create-master-policy-perm-list
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
@bryankaraffa
Copy link
Contributor

Added error if the PT is not in the "manually_verified_policy_templates" list which is used by the generate_permissions script

image

Copy link
Contributor

1 Error
🚫 tools/policy_master_permission_generation/README.md:15: MD014 Dollar signs used before commands without showing output

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Generated by 🚫 Danger

nia-vf1 and others added 2 commits February 2, 2024 10:26
…tes into POL-918-create-master-policy-perm-list
…1783)

* add google cud recommender policy to permissions list

* tested and add google cud recommender policy to permissions list
Copy link
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes

cost/azure/rightsize_compute_instances/README.md Outdated Show resolved Hide resolved
cost/azure/rightsize_compute_instances/README.md Outdated Show resolved Hide resolved
nia-vf1 and others added 3 commits February 12, 2024 13:36
* updated Permissions list to include Google Unlabeled Resources

* POL-1057 Google Unlabeled Resources - Update Permissions in README (#1813)

* Update README.md

* Sort permissions alphabetically in README

* Update README.md

Remove redundant IAM Role from Credential Configuration list

* Update README.md

Remove whitespace on line 53

* reran script with updated Google Unlabeled Resources README to produce correct Permissions list
Copy link
Contributor Author

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nia-vf1 nia-vf1 merged commit 5986305 into master Feb 12, 2024
11 of 12 checks passed
@nia-vf1 nia-vf1 deleted the POL-918-create-master-policy-perm-list branch February 12, 2024 15:14
@nia-vf1 nia-vf1 restored the POL-918-create-master-policy-perm-list branch February 12, 2024 15:22
@nia-vf1 nia-vf1 deleted the POL-918-create-master-policy-perm-list branch February 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants