Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-918 Create Master Policy Permissions List (2) Continued #1816

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

nia-vf1
Copy link
Contributor

@nia-vf1 nia-vf1 commented Feb 12, 2024

Remove redundant IAM Role from Credential Configuration list

  • Update README.md

Remove whitespace on line 53

  • reran script with updated Google Unlabeled Resources README to produce correct Permissions list

  • Updated permissions list to include Azure Untagged VMs


Description

Issues Resolved

Link to Example Applied Policy

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

* added policy permissions ruby script for parsing readmes for permissions

* added github workflow yaml file to automate running ruby script to create master policy permissions json file

* minor update to syntax to support older versions of ruby

* adding fileutils library to create the directory for the json file

* added exclude in gitignore for policy permissions json

* try using dist

* removed generated json file

* revert to ignoring the required "data/*" directory rather than dist

* test change

* add pull request in workflow

* Update Master Policy Permissions List (#1675)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* test revert back to original gitignore

* reverting as addition to .gitignore file is required for now

* Update Master Policy Permissions List (#1676)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* Update Master Policy Permissions List (#1680)

Co-authored-by: XOmniverse <XOmniverse@users.noreply.github.com>

* Delete data/policy_permissions_list/master_policy_permissions_list.json

* changed name of workflow yaml file

* Update Master Policy Permissions List (#1685)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* Delete data/policy_permissions_list directory

* updated name of workflow, and updated name of ruby script

* fix

* Update Policy Master Permissions List (#1687)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* remove master_policy_permissions json

* update ruby script to capture read-only field for permissions and roles

* add output to log

* fix read-only field for permissions/roles

* add logic to get description field, and correct boolean values for required and read-only permissions

* update json to not show "providers" field if no providers exist for a given policy template

* Update Policy Master Permissions List (#1724)

Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>

* task: use a statically defined list

* volumes (#1752)

* task: add aws_rightsize_rds_instances.pt (#1754)

* snapshot

* add aws_unused_ip_addresses.pt (#1757)

* task: add aws_unused_ip_addresses.pt

* rm character

* done (#1758)

* add aws_rightsize_ec2_instances.pt

* done (#1759)

* POL-918 AWS RI Recommendations (#1760)

* added aws ri recs to list

* remove json

* unused volumes (#1761)

* add azure_compute_rightsizing.pt (#1762)

* task: add `,`

* add azure_compute_rightsizing.pt

* update (#1764)

* add azure unused sql to list (#1763)

* add azure_delete_old_snapshots.pt (#1765)

* docs: Add missing permissions

* add azure_delete_old_snapshots.pt

* push latest datasets

* done (#1766)

* good (#1768)

* push latest dataset

* add azure_savings_plan_recommendations.pt (#1769)

* push latest dataset

* rightsize (#1771)

* add permission json and yaml

* google (#1773)

* cloud sql (#1774)

* feat: Add warning for new datasources and checking README for new permissions

* update (#1776)

* Add test new datasource

* fix test

* add debug loggin

* done (#1777)

* fix: update regex for new datasource blocks

* feat: Add check for new datasources and a warning to check README

* test: revert change to PT for testing

* feat: only check PT files

* fix: install ruby using feature in devcontainer

* move PT files list to separate file

* task: run  ruby tools/policy_master_permission_generation/generate_policy_master_permissions.rb

* feat: sort output datasets using id
mitigate/prevent large diffs between runs

* task: run  ruby tools/policy_master_permission_generation/generate_policy_master_permissions.rb

* fix: rm nvm from post commands

* feat: add error if PT not yet enabled

* test: add tmp test datasource

* fix: use fail instead of error

* task: update error message

* task: update wording in fail

* test: rm temporary test trigger

* test: add tmp datasource to test warning trigger

* fix: use include? to check if file matches

* test: rm test trigger

* docs: add README for policy permission generation

* docs: update branch name

* NVF/POL-918 1705958339 - Validate Google CUD Recommender permissions (#1783)

* add google cud recommender policy to permissions list

* tested and add google cud recommender policy to permissions list

* updated json, yaml to reflect most recent repository changes

* Updated permissions list to include AWS Rightsize RDS Instances and Azure Rightsize SQL Instances (#1809)

* Updated permissions list to include AWS Rightsize EBS Volumes and Azure Rightsize Managed Disks (#1810)

* Updated permissions list to include Azure Reserved Instances Utilization (#1811)

* Updated permissions list to include AWS Untagged Resources and Azure Untagged Resources (#1812)

* updated permissions Azure Rightsize Compute Instances README to remove white space before asterisk

* NVF/POL-918 Add Google Unlabeled Resources (#1814)

* updated Permissions list to include Google Unlabeled Resources

* POL-1057 Google Unlabeled Resources - Update Permissions in README (#1813)

* Update README.md

* Sort permissions alphabetically in README

* Update README.md

Remove redundant IAM Role from Credential Configuration list

* Update README.md

Remove whitespace on line 53

* reran script with updated Google Unlabeled Resources README to produce correct Permissions list

* Updated permissions list to include Azure Untagged VMs

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
Co-authored-by: XOmniverse <XOmniverse@users.noreply.github.com>
Co-authored-by: Bryan Karaffa <bryankaraffa@gmail.com>
Co-authored-by: Shawn Huckabay <shuckabay@flexera.com>
@nia-vf1 nia-vf1 self-assigned this Feb 12, 2024
@nia-vf1 nia-vf1 requested a review from a team as a code owner February 12, 2024 15:29
nia-vf1 and others added 4 commits February 12, 2024 15:38
…ped EC2 Instances (#1820)

* Updated Permissions list to include AWS Long Running Instances and Azure Long Running Instances

* Updated Permissions list to include AWS Long Stopped EC2 Instances
Copy link
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nia-vf1 nia-vf1 merged commit 6c6959b into master Feb 13, 2024
12 checks passed
@nia-vf1 nia-vf1 deleted the POL-918-create-master-policy-perm-list-continued branch February 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants