Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POL-1364 Update Azure Savings Plan Expiration - Fix Policy Set value #2663

Merged
merged 2 commits into from
Sep 23, 2024
Merged

POL-1364 Update Azure Savings Plan Expiration - Fix Policy Set value #2663

merged 2 commits into from
Sep 23, 2024

Conversation

nia-vf1
Copy link
Contributor

@nia-vf1 nia-vf1 commented Sep 23, 2024 •
edited
Loading

Description

The policy_set field in the policy template metadata has been changed from its current value of "Savings Plan" to "Savings Plans" .

Issues Resolved

This does not change the functionality of the policy but it does help us internally with reporting on templates in our repository.

Link to Example Applied Policy

Contribution Check List

  • New functionality has been documented in CHANGELOG.MD

@nia-vf1 nia-vf1 requested a review from a team as a code owner September 23, 2024 16:16
@nia-vf1 nia-vf1 self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

1 Warning
⚠️

cost/azure/savings_plan/expiration/azure_savings_plan_expiration.pt

Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
1 Message
📖

Github Pull Request

Pull Request is missing READY-FOR-REVIEW label. Please add this label if this Pull Request is ready for review.

Please note that this message may be a false positive if you've added the label after Dangerfile tests were run, since adding labels does not trigger them to run again. In these cases, simply ignore this message.

Generated by 🚫 Danger

XOmniverse
XOmniverse approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XOmniverse XOmniverse merged commit fc9da1c into master Sep 23, 2024
11 checks passed
@XOmniverse XOmniverse deleted the POL-1364-update-azure-savings-plan-expiration-policy-set-value branch September 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XOmniverse XOmniverse XOmniverse approved these changes

Assignees

@nia-vf1 nia-vf1

Labels
READY-FOR-REVIEW small fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nia-vf1 @XOmniverse