POL-1378 Linting Updates: Cost Policies: AWS

[XOmniverse]

Description

Various small changes to Security policies to bring them up to current linting standards. Also removes known bad coding patterns to avoid their reuse.

[github-actions]

	10 Warnings
⚠️	Important Files Modified Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation. .dangerfile/policy_tests.rb
⚠️	cost/aws/ec2_compute_optimizer/aws_ec2_compute_optimizer.pt Policy will not be published in the public catalog. If this is not the intended behavior, remove the publish field from the policy's info metadata block.
⚠️	cost/aws/extended_support/aws_extended_support.pt Recommendation policy has export that is missing recommended fields. These fields are scraped by the Flexera platform for dashboards: Line 422: resourceName, tags
⚠️	cost/aws/instance_cost_per_hour/aws_instance_cost_per_hour.pt Policy will not be published in the public catalog. If this is not the intended behavior, remove the publish field from the policy's info metadata block. Possible invalid spacing between comma-separated items found: Line 426: chartAxisFormat: encodeURI("chxs=0N*c" + ds_currency['code'] + "2z*|1,min40"), Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
⚠️	cost/aws/object_storage_optimization/aws_object_storage_optimization.pt Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.
⚠️	cost/aws/rightsize_elasticache/aws_rightsize_elasticache.pt Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
⚠️	cost/aws/rightsize_redshift/aws_rightsize_redshift.pt Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
⚠️	cost/aws/s3_bucket_size/aws_bucket_size.pt Possible invalid spacing between comma-separated items found: Line 40: description "The number of GiB of space a bucket needs to exceed to include it in the results. Binary gibibytes (e.g. 1,073,741,824 bytes in a gibibyte) are used to maintain parity with how AWS S3 storage is billed." Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
⚠️	cost/aws/s3_storage_policy/aws_s3_bucket_policy_check.pt Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.
⚠️	cost/aws/schedule_instance/aws_schedule_instance.pt Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.

Generated by 🚫 Danger

Outstanding conversation to be resolved

[nia-vf1]

LGTM