Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1378 Linting Updates: Cost Policies: Google #2736

Merged
merged 186 commits into from
Oct 16, 2024

Conversation

XOmniverse
Copy link
Contributor

@XOmniverse XOmniverse commented Oct 8, 2024

Description

Various small changes to Google Cost policies to bring them up to current linting standards. Also removes known bad coding patterns to avoid their reuse.

@XOmniverse XOmniverse requested a review from a team as a code owner October 8, 2024 20:41
Copy link
Contributor

github-actions bot commented Oct 8, 2024

2 Warnings
⚠️

Important Files Modified

Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation.

.dangerfile/policy_tests.rb

⚠️

cost/google/cloud_run_anomaly_detection/google_cloud_run_anomaly_detection.pt

Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.


Policy will not be published in the public catalog. If this is not the intended behavior, remove the publish field from the policy's info metadata block.

Generated by 🚫 Danger

@nia-vf1 nia-vf1 self-assigned this Oct 16, 2024
Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nia-vf1 nia-vf1 assigned XOmniverse and unassigned nia-vf1 Oct 16, 2024
@XOmniverse XOmniverse merged commit 1892db3 into master Oct 16, 2024
11 checks passed
@XOmniverse XOmniverse deleted the POL-1378-linting-cost-google branch October 16, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants