Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1386 Dangerfile Improvements #2753

Merged
merged 182 commits into from
Oct 14, 2024
Merged

Conversation

XOmniverse
Copy link
Contributor

Description

  • Adds a test for whether verb "GET" is in use
  • Updates comma separation test to have fewer false positives

@XOmniverse XOmniverse requested a review from a team as a code owner October 14, 2024 15:13
Copy link
Contributor

github-actions bot commented Oct 14, 2024

1 Warning
⚠️

Important Files Modified

Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation.

.dangerfile/policy_tests.rb
Dangerfile

Generated by 🚫 Danger

Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XOmniverse XOmniverse merged commit 78d9786 into master Oct 14, 2024
11 checks passed
@XOmniverse XOmniverse deleted the POL-1386-dangerfile-improvement branch October 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants