Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1391 Azure Rightsize Compute Instances: Downsize Multiple Tiers #2762

Merged
merged 186 commits into from
Oct 21, 2024

Conversation

XOmniverse
Copy link
Contributor

@XOmniverse XOmniverse commented Oct 16, 2024

Description

Adds option to make recommendations to go down multiple sizes in the Azure Rightsize Compute Instances policy template.

Link to Example Applied Policy

https://app.flexera.com/orgs/6/automation/applied-policies/projects/7954?policyId=670ff9e623df560d6a3ad949

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

@XOmniverse XOmniverse requested a review from a team as a code owner October 16, 2024 17:33
Copy link
Contributor

1 Warning
⚠️

cost/azure/rightsize_compute_instances/azure_compute_rightsizing.pt

Possible invalid spacing between comma-separated items found:

Line 765: "aggregation": "average,maximum,minimum"

Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear

1 Message
📖

Github Pull Request

Pull Request is missing READY-FOR-REVIEW label. Please add this label if this Pull Request is ready for review.

Please note that this message may be a false positive if you've added the label after Dangerfile tests were run, since adding labels does not trigger them to run again. In these cases, simply ignore this message.

Generated by 🚫 Danger

Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nia-vf1 nia-vf1 assigned XOmniverse and unassigned nia-vf1 Oct 21, 2024
@XOmniverse XOmniverse merged commit 764f574 into master Oct 21, 2024
11 checks passed
@XOmniverse XOmniverse deleted the POL-1391-azure-rightsize-multilevel branch October 21, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants