Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-1404 AWS Superseded EBS Volumes - Fix Currency Conversion Message in Policy Incident #2777

Conversation

nia-vf1
Copy link
Contributor

@nia-vf1 nia-vf1 commented Oct 23, 2024

Description

This change fixes a bug in the policy incident of the AWS Superseded EBS Volumes policy in a customer's tenant.

This bug occurs when the customer’s native currency in the platform is not USD:

“Price and savings values are in USD due to a malfunction with Flexera's internal currency conversion API. Please contact Flexera support to report this issue.”

This message is incorrectly showing even though currency conversion was successful.

This change fixes this bug.

Issues Resolved

Fixes a bug where the Currency Conversion messaging in the policy incident is incorrectly showing.

Link to Example Applied Policy

Tested in customer tenant.

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in CHANGELOG.MD

@nia-vf1 nia-vf1 added bug Something isn't working DO-NOT-MERGE labels Oct 23, 2024
@nia-vf1 nia-vf1 self-assigned this Oct 23, 2024
@nia-vf1 nia-vf1 requested a review from a team as a code owner October 23, 2024 13:52
Co-authored-by: nia-vf1 <nia-vf1@users.noreply.github.com>
Copy link
Contributor

1 Warning
⚠️

cost/aws/superseded_ebs_volumes/aws_superseded_ebs_volumes.pt

Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.

1 Message
📖

Github Pull Request

Pull Request is missing READY-FOR-REVIEW label. Please add this label if this Pull Request is ready for review.

Please note that this message may be a false positive if you've added the label after Dangerfile tests were run, since adding labels does not trigger them to run again. In these cases, simply ignore this message.

Generated by 🚫 Danger

Copy link
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nia-vf1 nia-vf1 merged commit bf2962a into master Oct 24, 2024
11 checks passed
@nia-vf1 nia-vf1 deleted the POL-1404-aws-superseded-ebs-volumes-fix-currency-conversion-message branch October 24, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working READY-FOR-REVIEW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants