You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR marks the last update for the Hide Skip Approval task.
✅ The first phase, updating AWS Right Size policies, is complete in PR-2799.
✅ Additionally, the metaparent policy compiler and Rakefile have been successfully updated : PR-2813
Current Phase (Phase 2):
In this phase, we have added the hide_skip_approvals field to the info section of policy templates that do not use the request approval option in any escalation. This field allows the UI to dynamically show or hide the "Skip Approval" option based on the policy’s configuration. Following the AWS Right Size policy updates, these changes have now been applied to all remaining active policies.
Recommendation policy has export that is missing required fields. These fields are scraped by the Flexera platform for dashboards:
Line 1170: accountID, accountName, resourceID, service, savingsCurrency
Line 1332: accountID, accountName, resourceID, service, savingsCurrency
🚫
cost/flexera/cco/new_usage/new_usage.pt
run_script statements found whose parameters are not in the correct order. run_script parameters should be in the following order: script, val(iter_item, string), datasources, parameters, variables, raw values:
Line 253: ds_current_bill / run_script $js_get_bill
run_script statements found whose parameters are not in the correct order. run_script parameters should be in the following order: script, val(iter_item, string), datasources, parameters, variables, raw values:
Line 230: ds_current_products_oldconnection / run_script $js_get_products_oldconnection
Line 326: ds_current_products_newconnection / run_script $js_get_products_newconnection
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
Policy Template has indentation issues. Code should be indented with 2 spaces inside each do/end block, info() block, and EOS block, with additional spacing for nested blocks as appropriate:
Line 168: Expected indentation of 6 spaces but found 8 spaces.
Line 169: Expected indentation of 6 spaces but found 8 spaces.
Line 170: Expected indentation of 6 spaces but found 8 spaces.
Line 171: Expected indentation of 6 spaces but found 8 spaces.
Line 172: Expected indentation of 6 spaces but found 8 spaces.
Line 173: Expected indentation of 6 spaces but found 8 spaces.
Line 174: Expected indentation of 6 spaces but found 8 spaces.
Line 175: Expected indentation of 6 spaces but found 8 spaces.
Line 176: Expected indentation of 6 spaces but found 8 spaces.
Line 192: Expected indentation of 4 spaces but found 16 spaces.
Line 193: Expected indentation of 4 spaces but found 16 spaces.
Line 194: Expected indentation of 4 spaces but found 16 spaces.
Line 195: Expected indentation of 4 spaces but found 16 spaces.
Line 196: Expected indentation of 4 spaces but found 16 spaces.
Line 197: Expected indentation of 4 spaces but found 16 spaces.
Line 198: Expected indentation of 4 spaces but found 16 spaces.
Line 199: Expected indentation of 4 spaces but found 16 spaces.
parameter code blocks with missing default field found. Please add the default field to these blocks:
Line 54
Line 63
Optionally, you can add a comment within the parameter code blocks to indicate that the parameter requires user input and avoid this message.
# No default value, user input required
While not required, it is recommended that every parameter have a default value unless user input for that parameter is required and too specific for any default value to make sense
Datasources and scripts with mismatched names found. These names should match; for example, a datasource named ds_currency should be paired with a script named js_currency. This convention should only be ignored when the same script is called by multiple datasources. The following datasource/script pairs have mismatched names:
Line 209: ds_formatted_instances / js_format_instances
Possible invalid spacing between comma-separated items found:
Line 123: field "subscriptionId", jmes_path(col_item,"subscriptionId")
Line 124: field "displayName", jmes_path(col_item,"displayName")
Line 125: field "state", jmes_path(col_item,"state")
Line 159: path join(["/subscriptions/", val(iter_item,"subscriptionId"), "/providers/Microsoft.Compute/virtualMachines"])
Line 168: field "id", jmes_path(col_item,"id")
Line 169: field "name", jmes_path(col_item,"name")
Line 170: field "resourcename", get(4, split(jmes_path(col_item, "id"),"/"))
Line 171: field "location", jmes_path(col_item,"location")
Line 172: field "vmSize", jmes_path(col_item,"properties.hardwareProfile.vmSize")
Line 173: field "osType", jmes_path(col_item,"properties.storageProfile.osDisk.osType")
Line 174: field "tags", jmes_path(col_item,"tags")
Line 175: field "subscriptionId",val(iter_item,"subscriptionId")
Line 176: field "subscriptionName",val(iter_item,"displayName")
Line 203: collect xpath(response,"//NewDataSet/SearchResults") do
Line 294: path join(["/api/governance/projects/", rs_project_id, "/applied_policies/", switch(ne(meta_parent_policy_id,""), meta_parent_policy_id, policy_id) ])
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
parameter code blocks with missing default field found. Please add the default field to these blocks:
Line 29
Optionally, you can add a comment within the parameter code blocks to indicate that the parameter requires user input and avoid this message.
# No default value, user input required
While not required, it is recommended that every parameter have a default value unless user input for that parameter is required and too specific for any default value to make sense
Possible invalid spacing between comma-separated items found:
Line 110: check eq(to_n(val(item,"expiring")),0)
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
parameter code blocks with missing default field found. Please add the default field to these blocks:
Line 30
Optionally, you can add a comment within the parameter code blocks to indicate that the parameter requires user input and avoid this message.
# No default value, user input required
While not required, it is recommended that every parameter have a default value unless user input for that parameter is required and too specific for any default value to make sense
Possible invalid spacing between comma-separated items found:
Line 108: check eq(to_n(val(item,"ignored")),0)
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
parameter code blocks with missing default field found. Please add the default field to these blocks:
Line 30
Optionally, you can add a comment within the parameter code blocks to indicate that the parameter requires user input and avoid this message.
# No default value, user input required
While not required, it is recommended that every parameter have a default value unless user input for that parameter is required and too specific for any default value to make sense
Possible invalid spacing between comma-separated items found:
Line 108: check eq(to_n(val(item,"missing")),0)
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
parameter code blocks with missing default field found. Please add the default field to these blocks:
Line 21
Optionally, you can add a comment within the parameter code blocks to indicate that the parameter requires user input and avoid this message.
# No default value, user input required
While not required, it is recommended that every parameter have a default value unless user input for that parameter is required and too specific for any default value to make sense
Possible invalid spacing between comma-separated items found:
Line 100: check eq(size(data),0)
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
⚠️
cost/aws/s3_bucket_size/aws_bucket_size.pt
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
Possible invalid spacing between comma-separated items found:
Line 41: description "The number of GiB of space a bucket needs to exceed to include it in the results. Binary gibibytes (e.g. 1,073,741,824 bytes in a gibibyte) are used to maintain parity with how AWS S3 storage is billed."
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
⚠️
cost/aws/s3_lifecycle/aws_s3_lifecycle.pt
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.
Possible invalid spacing between comma-separated items found:
Line 569: "metricnames": "OS Disk IOPS Consumed Percentage,OS Disk Bandwidth Consumed Percentage,Data Disk IOPS Consumed Percentage,Data Disk Bandwidth Consumed Percentage",
Comma separated items should be organized as follows, with a single space following each comma: apple, banana, pear
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR marks the last update for the Hide Skip Approval task.
✅ The first phase, updating AWS Right Size policies, is complete in PR-2799.
✅ Additionally, the metaparent policy compiler and Rakefile have been successfully updated : PR-2813
Current Phase (Phase 2):
In this phase, we have added the hide_skip_approvals field to the info section of policy templates that do not use the request approval option in any escalation. This field allows the UI to dynamically show or hide the "Skip Approval" option based on the policy’s configuration. Following the AWS Right Size policy updates, these changes have now been applied to all remaining active policies.
More context: Seeking Your Input: Proposed Solution for Conditional "Skip Approvals" Visibility
Issues Resolved
FLEX-5397
Contribution Check List