Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tensor shapes for elementwise binary operations with broadcasting #1234

Merged
merged 13 commits into from
Dec 1, 2023

Conversation

soumyac1999
Copy link
Collaborator

@soumyac1999 soumyac1999 commented Nov 24, 2023

Moved from #738

Description of changes:

Example: [16, 1, 2] + [16, 1552, 1] has output shape of [16, 1552, 2] but the existing code was setting the size to [16, 1, 2].

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

@soumyac1999
Copy link
Collaborator Author

Hi @jiazhihao, could you please re-review this PR? You had already reviewed it in #738 but I wasn't able to get the CI working there so created this new PR.

@jiazhihao jiazhihao enabled auto-merge (squash) November 30, 2023 22:10
@jiazhihao jiazhihao merged commit 5501cf8 into inference Dec 1, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate possible issues in output shape computation in keras/layers/merge.py
2 participants