Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Library #1521

Open
wants to merge 7 commits into
base: repo-refactor
Choose a base branch
from

Conversation

Marsella8
Copy link

@Marsella8 Marsella8 commented Oct 10, 2024

Description of changes:

Extending testing functionality for graph library
Bug fixing
General clean up

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 89.96656% with 60 lines in your changes missing coverage. Please review.

Project coverage is 79.22%. Comparing base (1d5140d) to head (e7055ad).

Files with missing lines Patch % Lines
.../undirected/algorithms/get_connected_components.cc 0.00% 41 Missing ⚠️
.../utils/graph/instances/hashmap_undirected_graph.cc 37.50% 10 Missing ⚠️
lib/utils/src/utils/graph/algorithms.cc 0.00% 3 Missing ⚠️
.../graph/instances/unordered_set_undirected_graph.cc 0.00% 2 Missing ⚠️
...rc/utils/graph/undirected/undirected_edge_query.cc 0.00% 2 Missing ⚠️
...aph/undirected/algorithms/get_neighboring_nodes.cc 0.00% 1 Missing ⚠️
...tils/src/utils/graph/undirected/undirected_edge.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           repo-refactor    #1521      +/-   ##
=================================================
+ Coverage          78.16%   79.22%   +1.06%     
=================================================
  Files                860      873      +13     
  Lines              27994    28464     +470     
  Branches             770      770              
=================================================
+ Hits               21881    22552     +671     
+ Misses              6113     5912     -201     
Flag Coverage Δ
unittests 79.22% <89.96%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/utils/graph/dataflow_graph/dataflow_graph.h 50.00% <ø> (ø)
lib/utils/include/utils/graph/digraph/digraph.h 100.00% <ø> (ø)
...b/utils/include/utils/graph/digraph/digraph_view.h 100.00% <ø> (ø)
...ls/include/utils/graph/multidigraph/multidigraph.h 100.00% <ø> (ø)
lib/utils/include/utils/graph/node/graph_view.h 100.00% <ø> (ø)
.../include/utils/graph/undirected/undirected_graph.h 100.00% <ø> (ø)
...ude/utils/graph/undirected/undirected_graph_view.h 100.00% <ø> (+20.00%) ⬆️
.../utils/graph/series_parallel/parallel_reduction.cc 100.00% <100.00%> (ø)
lib/utils/src/utils/graph/views/views.cc 85.29% <100.00%> (+60.14%) ⬆️
...t/src/utils/graph/digraph/algorithms/algorithms.cc 100.00% <100.00%> (ø)
... and 16 more

... and 13 files with indirect coverage changes

@Marsella8 Marsella8 marked this pull request as ready for review October 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant