Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ff_dim to ff_dim_t, added in nonnegative_int type #1533

Draft
wants to merge 1 commit into
base: repo-refactor
Choose a base branch
from

Conversation

victorli2002
Copy link
Collaborator

@victorli2002 victorli2002 commented Oct 31, 2024

Description of changes:

  • draft
  • renamed ff_dim to ff_dim_t
  • added a nonnegative_int type with some unit tests
  • added a relative_ff_dim_t type for now (unused)

This change is Reviewable

@victorli2002 victorli2002 reopened this Oct 31, 2024
@victorli2002 victorli2002 marked this pull request as draft October 31, 2024 04:55
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (1d5140d) to head (f9fe89b).

Files with missing lines Patch % Lines
...utils/src/utils/nonnegative_int/nonnegative_int.cc 87.06% 15 Missing ⚠️
lib/local-execution/src/legion_tensor_shape.cc 0.00% 4 Missing ⚠️
lib/kernels/src/array_shape.cc 0.00% 2 Missing ⚠️
lib/kernels/src/legion_dim.cc 0.00% 2 Missing ⚠️
lib/local-execution/src/ops/gather.cc 0.00% 1 Missing ⚠️
lib/local-execution/src/ops/layer_norm.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           repo-refactor    #1533    +/-   ##
===============================================
  Coverage          78.16%   78.17%            
===============================================
  Files                860      863     +3     
  Lines              27994    28473   +479     
  Branches             770      779     +9     
===============================================
+ Hits               21881    22258   +377     
- Misses              6113     6215   +102     
Flag Coverage Δ
unittests 78.17% <91.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/kernels/include/kernels/legion_dim.h 25.00% <ø> (-3.58%) ⬇️
lib/local-execution/src/ops/linear.cc 0.00% <ø> (ø)
...p-attrs/include/op-attrs/dim_ordered/dim_ordered.h 81.69% <ø> (-0.67%) ⬇️
lib/op-attrs/include/op-attrs/ff_dim_t.h 100.00% <ø> (ø)
lib/op-attrs/test/src/op-attrs/dim_ordered/zip.cc 100.00% <ø> (ø)
...ls/include/utils/nonnegative_int/nonnegative_int.h 100.00% <100.00%> (ø)
.../test/src/utils/nonnegative_int/nonnegative_int.cc 100.00% <100.00%> (ø)
lib/local-execution/src/ops/gather.cc 0.00% <0.00%> (ø)
lib/local-execution/src/ops/layer_norm.cc 0.00% <0.00%> (ø)
lib/kernels/src/array_shape.cc 20.83% <0.00%> (ø)
... and 3 more

... and 111 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant