Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference: Sampling result #854

Merged
merged 19 commits into from
Jul 19, 2023
Merged

Conversation

xinhaoc
Copy link
Collaborator

@xinhaoc xinhaoc commented Jul 11, 2023

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Jul 11, 2023

before:

I believe the meaning of life is to live it to the fullest and to enjoy every moment of it.
I believe that the meaning of life is to live it to the fullest and to enjoy every moment of it.
I believe that the meaning of life is to live it to the fullest and to enjoy every moment of it. I believe that the meaning of life is to live it to the fullest and to enjoy every moment of it. I believe that the meaning of life is to live it to the fullest and to enjoy every moment of it. I believe that the meaning of life is to live it

after

 I believe the meaning of life is to live life to the fullest and not waste it. I believe everyone is born with a purpose and that is to find that purpose and live it out to the fullest. I believe everyone has a gift that God has given them and that gift is meant to be shared with the world. I believe the meaning of life is to live a full life. 2019- B H Hy S: T Spring Su B Ford:-/ N R H Toy Bu A Che I Maz W MA- is Vol Se B was International is Toy Maz F N- April is

it will avoid the repeat sentence, but also generate some meaningless tokens at the end. need to find a way to address this problem.
this is due to the gneration config params, like top_p value, temperature value.

@xinhaoc xinhaoc marked this pull request as ready for review July 13, 2023 07:08
@xinhaoc xinhaoc requested a review from jiazhihao July 14, 2023 02:31
@jiazhihao jiazhihao enabled auto-merge (squash) July 18, 2023 01:30
@goliaro goliaro added the inference Features and fixes related to the inference project. label Jul 18, 2023
@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Jul 18, 2023

I think we can merge this PR.

@jiazhihao jiazhihao merged commit d3cd370 into flexflow:inference Jul 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inference Features and fixes related to the inference project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants