Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Group attention (Llama 2) #883

Merged
merged 28 commits into from
Aug 3, 2023
Merged

Conversation

xinhaoc
Copy link
Collaborator

@xinhaoc xinhaoc commented Jul 23, 2023

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

@goliaro goliaro added the inference Features and fixes related to the inference project. label Jul 24, 2023
@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Jul 25, 2023

Give three tips for staying healthy.
The first step is to make sure you are getting enough sleep.
The second step is to make sure you are eating healthy foods.
The third step is to make sure you are exercising regularly.
The fourth step is to make sure you are taking care of your mental health.
The fifth step is to make sure you are taking care of your physical health.
The sixth step is to make sure you are taking care of your emotional health.
The seventh step is to make sure you are taking care of your spiritual health.

@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Aug 1, 2023

result from llama 70B:

⁇ Give three tips for staying healthy.

  1. Eat a balanced diet. 2. Exercise regularly. 3. Get enough sleep.
  2. What is the best way to stay healthy?
  3. What are some tips for staying healthy?
  4. How can I stay healthy?
  5. What are some ways to stay healthy?
  6. How can I maintain my health?
  7. What are some healthy habits?
  8. What are some healthy lifestyle choices?
  9. How can I improve my health?

or
Give three tips for staying healthy.
What are the three tips for staying healthy?
What are the 3 tips for staying healthy?
What are the 3 tips for staying healthy Brainly?
What are the 3 tips for staying healthy answer?
What are the 3 tips for staying healthy answer in one word?
What are the 3 tips for staying healthy answer in one word Brainly?
What are the 3 tips for staying healthy answer in one word 2021?
What are the

@jiazhihao
Copy link
Collaborator

It seems this PR has passed CI. @xinhaoc @goliaro do you think we can merge it to the inference branch now? In this case, we will add LLaMA 2 support on the Python side later.

@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Aug 2, 2023

One more thing to do, the quantization is not supported yet.

@xinhaoc
Copy link
Collaborator Author

xinhaoc commented Aug 2, 2023

and do you think we should fix this issue #908 in this branch?

@jiazhihao
Copy link
Collaborator

We can add the quantization support in a separate PR.

@jiazhihao
Copy link
Collaborator

We can add the quantization support in a separate PR.

If the fix is not too hard, I think it's a good idea to fix them in this PR.

@xinhaoc xinhaoc requested a review from goliaro August 2, 2023 17:27
@goliaro goliaro marked this pull request as ready for review August 2, 2023 19:19
@goliaro goliaro enabled auto-merge (squash) August 2, 2023 19:19
@goliaro goliaro disabled auto-merge August 2, 2023 23:58
@goliaro goliaro enabled auto-merge (squash) August 3, 2023 03:42
@goliaro goliaro merged commit d1ef0ed into flexflow:inference Aug 3, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inference Features and fixes related to the inference project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants