Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci update #898

Merged
merged 10 commits into from
Aug 8, 2023
Merged

Ci update #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4067b5
Update clang format checking
aquan9 Jul 28, 2023
9445587
Separate out the checking of each subdirectory in lib
aquan9 Jul 28, 2023
48f1af7
Remove old directories from format check
aquan9 Jul 28, 2023
bbe5c84
Break up lib/runtime even further in format checking for parallelism
aquan9 Jul 28, 2023
880acca
Disable fail-fast so that format reporting is thorough
aquan9 Jul 28, 2023
8f00ac4
Remove unnecessary format checks.
aquan9 Jul 31, 2023
8cc44f2
Merge remote-tracking branch 'origin/repo-refactor' into ci-update
lockshaw Aug 8, 2023
b55ad05
Move over to use clang-format-16 and correct config file
lockshaw Aug 8, 2023
af94a17
Update clang-format-check version
lockshaw Aug 8, 2023
8f08aed
Update to v3
lockshaw Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .clang-tidy-15
View file
Open in desktop

This file was deleted.

20 changes: 12 additions & 8 deletions .github/workflows/clang-format-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,25 @@ jobs:
name: Formatting Check
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
path:
- check: "src"
exclude: '\.proto$'
- check: "include"
- check: "nmt"
- check: "python"
- check: "scripts"
- check: "lib/compiler"
- check: "lib/ffi"
- check: "lib/kernels"
- check: "lib/op-attrs"
- check: "lib/pcg"
- check: "lib/runtime"
- check: "lib/substitutions"
- check: "lib/utils"
- check: "tests"
- check: "examples"
- check: "bindings"
steps:
- uses: actions/checkout@v2
- name: Run clang-format style check for C/C++/Protobuf programs.
uses: jidicula/clang-format-action@v4.8.0
uses: lockshaw/clang-format-action@v4.11.0-flexflow-3
with:
clang-format-version: "15"
clang-format-version: "16"
check-path: ${{ matrix.path['check'] }}
exclude-regex: ${{ matrix.path['exclude'] }}
8 changes: 3 additions & 5 deletions lib/utils/include/utils/test_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,9 @@ namespace std {
template <
::FlexFlow::test_types::
capability... CAPABILITIES> //, typename = typename
//std::enable_if<::FlexFlow::test_types::has_capability<::FlexFlow::test_types::HASHABLE>::value,
//bool>::type>
struct hash<
::FlexFlow::test_types::test_type_t<
CAPABILITIES...>> {
// std::enable_if<::FlexFlow::test_types::has_capability<::FlexFlow::test_types::HASHABLE>::value,
// bool>::type>
struct hash<::FlexFlow::test_types::test_type_t<CAPABILITIES...>> {
typename std::enable_if<
::FlexFlow::test_types::has_capability<::FlexFlow::test_types::HASHABLE,
CAPABILITIES...>::value,
Expand Down
2 changes: 1 addition & 1 deletion scripts/format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fi
CLANG_FORMAT_CONFIG="$GIT_ROOT/.clang-format-for-format-sh"
mapfile -t FILES < <(git ls-files ':!:triton/**' '*.h' '*.cc' '*.cpp' '*.cu' '*.c')
if [[ -f $CLANG_FORMAT_CONFIG ]]; then
"$CLANG_FORMAT_PATH" -style=file:"$CLANG_FORMAT_CONFIG" -i "${FILES[@]}"
"$CLANG_FORMAT_PATH" --style=file:"$CLANG_FORMAT_CONFIG" -i "${FILES[@]}"
else
echo "error"
fi
Loading