Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recurse_n #1563

Merged
merged 2 commits into from
Dec 25, 2024
Merged

added recurse_n #1563

merged 2 commits into from
Dec 25, 2024

Conversation

Marsella8
Copy link
Contributor

@Marsella8 Marsella8 commented Dec 21, 2024

Description of changes:

added recurse_n function in containers library

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marsella8)


lib/utils/src/utils/containers/recurse_n.cc line 1 at r1 (raw file):

#include "utils/containers/recurse_n.h"

Can you add a value_type specialization to force it to typecheck? (example: https://github.com/flexflow/FlexFlow/blob/89c143d33b9e02faf8d6818a9c47b0d5da68a610/lib/utils/src/utils/containers/get_all_assignments.cc)

Copy link
Contributor Author

@Marsella8 Marsella8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lockshaw)


lib/utils/src/utils/containers/recurse_n.cc line 1 at r1 (raw file):

Previously, lockshaw (Colin Unger) wrote…

Can you add a value_type specialization to force it to typecheck? (example: https://github.com/flexflow/FlexFlow/blob/89c143d33b9e02faf8d6818a9c47b0d5da68a610/lib/utils/src/utils/containers/get_all_assignments.cc)

The things we have to do to mimick generics...
Let me know if this is what you were thinking (I've verified that it does actually complain at compile time)

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Marsella8)

@lockshaw lockshaw merged commit 186e8eb into flexflow:master Dec 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants