Fix Reference & Manager compatibility with React 18's StrictMode (#459)

floating-ui · May 8, 2024 · 2bbdd4a · 2bbdd4a
1 parent beac280
commit 2bbdd4a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Manager.js b/src/Manager.js
@@ -15,6 +15,7 @@ export function Manager({ children }: ManagerProps): React.Node {
 
   const hasUnmounted = React.useRef(false);
   React.useEffect(() => {
+    hasUnmounted.current = false;
     return () => {
       hasUnmounted.current = true;
     };

diff --git a/src/Reference.js b/src/Reference.js
@@ -22,10 +22,6 @@ export function Reference({ children, innerRef }: ReferenceProps): React.Node {
     [innerRef, setReferenceNode]
   );
 
-  // ran on unmount
-  // eslint-disable-next-line react-hooks/exhaustive-deps
-  React.useEffect(() => () => setRef(innerRef, null), []);
-
   React.useEffect(() => {
     warning(
       Boolean(setReferenceNode),