Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync on local change doesn't work #1417

Closed
BloodyIron opened this issue Oct 11, 2023 · 20 comments
Closed

Sync on local change doesn't work #1417

BloodyIron opened this issue Oct 11, 2023 · 20 comments
Labels

Comments

@BloodyIron
Copy link

BloodyIron commented Oct 11, 2023

Describe the feature you'd like to request

5 minute background sync is generally fine to sync downloads of bookmarks. But when I'm adding/deleting bookmarks I really don't want to have to manually trigger sync each time, or even risk shutting my computer down before the next timed sync and losing that sync consistency.

I would like a setting where in addition to timed syncs, if the client detects a local bookmark change (add/delete/move/etc) that does not meant the "Destructive threshold" (50% default I think?) that it automatically and immediately syncs those changes (after waiting say... 5 seconds or something like that). And if each time it triggers any future notification stuff, I'm okay with that.

Namely I work with a high productivity pace, and 5 minutes timed periodic sync isn't sufficient for me in certain regards (but sometimes it is).

Anyways, if we could get something like this, that would be super awesome. Thanks! :)

Describe the solution you'd like

Already described. Why is this even required?

Describe alternatives you've considered

Currently I just manually trigger the sync after any change that I make, as generally any change I make I need (even moving folders for bookmarks).

@marcelklehr
Copy link
Member

detects a local bookmark change (add/delete/move/etc) that does not meant the "Destructive threshold" (50% default I think?) that it automatically and immediately syncs those changes (after waiting say... 5 seconds or something like that)

This is already implemented. It should sync 7 seconds after a bookmark was changed. If that doesn't work atm, then it's a bug.

@BloodyIron
Copy link
Author

@marcelklehr I will aspire to test that at some point, thanks!

@BloodyIron
Copy link
Author

Yeah the 7 second thing is not happening for me. I've given it over a minute after adding a bookmark and it still has not sync'd. v4.19.1

The way I can "tell" is the plugin reports time since sync'd, shows 10 minutes.... wait... then 11 minutes.... 12 minutes... which if that's accurate tells me it did not auto sync immediately-ish ;)

@marcelklehr marcelklehr changed the title Sync on local change frequency setting Sync on local change doesn't work Dec 6, 2023
@gvegidy
Copy link

gvegidy commented Dec 9, 2023

Just to add a datapoint:

for me the auto-sync 7 seconds after a local change works fine. Firefox 120.0.1 on Fedora Linux x86_64, Floccus 5.0.0.

I consider this auto-sync a good idea, thanks for implementing it.

@marcelklehr
Copy link
Member

@gvegidy Yes, it was fixed with v5.0.0, thanks for the feedback!

@BloodyIron
Copy link
Author

@marcelklehr when does the update hit the Chrome Plugin ecosystem? I don't think my "browser" sees it yet... or something like that 🤔

@marcelklehr
Copy link
Member

Yes, chrome webstore is still reviewing the release

@BloodyIron
Copy link
Author

@marcelklehr don't yet see the update on the Chrome Store. Am I doing something wrong, or?

@marcelklehr
Copy link
Member

@BloodyIron No, I've paused the release on chrome until the most problematic issues have been resolved with v5 that transpired after releasing on firefox

@BloodyIron
Copy link
Author

@marcelklehr is there a particular version milestone I should watch for in the skies? As in, a version you're roughly aiming to have such things "solved" in? I can appreciate it's not so easy of a thing to define sometimes, but if you have a such a target "version" in your mind already, I'd like to know so I can watch quietly while I look forward to all this stuff rolling out. :)

Also, thanks for the insights into what's going on! Isn't it such a bother when you release a bunch of work only to have to roll it back? :P It happens!

@marcelklehr
Copy link
Member

@BloodyIron The issues i was referring to have been resolved now. I've submitted v5.0.6 for review on chrome web store and will try to gradually roll out the release for chrome to avoid bombing all users at once, in case there's new trouble...

@marcelklehr
Copy link
Member

Staged rollout of v5.0.6 on chrome web store has just started

@BloodyIron
Copy link
Author

@marcelklehr yay thanks! And also thanks for your hard work and all the work of others too! \o/ Seriously, this plugin really is fabulous for my workflow :)

@BloodyIron
Copy link
Author

@marcelklehr I'm new to the auto-updating aspect of Chrome plugins. From a UX perspective, should I "expect" that Chrome's Plugin ecosystem will auto-update itself, or should I be manually checking to "apply update" (or equivalent) kind of thing?

Not trying to pressure you to go faster here, more trying to set my reasonable expectations of what to watch for. :) Thanks again!

@marcelklehr
Copy link
Member

Yes, v5.x will reach you at some point, I'm currently at 5% rollout :)

@BloodyIron
Copy link
Author

@marcelklehr I think you misunderstand. Does the Chrome plugin ecosystem auto-update plugins when an update rolls out? I haven't bothered in the past to ever check.

@marcelklehr
Copy link
Member

If you're eager to try the new version you can also download it here (extract the zip and drop into your chrome://extensions page, I believe):
fnaicdffflnofjppbagibeoednhnbjhg.zip

@marcelklehr
Copy link
Member

Does the Chrome plugin ecosystem auto-update plugins when an update rolls out?

Yes, once you install a plugin, chrome will keep it up to date.

@BloodyIron
Copy link
Author

Does the Chrome plugin ecosystem auto-update plugins when an update rolls out?

Yes, once you install a plugin, chrome will keep it up to date.

Thanks! :)

@marcelklehr marcelklehr moved this to Done in Floccus May 19, 2024
Copy link

github-actions bot commented Jan 9, 2025

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants