Add IAuthZone
#76
Merged
Add IAuthZone
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ forge bind --overwrite -b bindings/rust $ git clean -f
fulminmaxi
approved these changes
Nov 9, 2023
src/zone/extensions/IAuthZone.sol
Outdated
| RangeFilter nonce; | ||
| } | ||
|
|
||
| function setAuthorizationFilter(address actor, Filter calldata filter) external; |
There was a problem hiding this comment.
I think can be left out of the interface, as one could want to write a zone where this is never set, just returned from authoriazionFilter
For example a Zone allowing everybody:
function authorizationFilter(address actor) external view returns (Filter memory) {
return Filter({initialized: true, offerer: address(0)}) etc...
src/zone/extensions/MainZone.sol
Outdated
| emit FilterUpdated(actor, filter); | ||
| } | ||
|
|
||
| function authorizationFilter(address actor) external view returns (Filter memory) { |
There was a problem hiding this comment.
we could use the mapping directly by calling it authorizationFilter
src/zone/extensions/IAuthZone.sol
Outdated
| RangeFilter amount; | ||
| } | ||
|
|
||
| struct Filter { |
There was a problem hiding this comment.
Question, can we "invert" the filter?
For example if we want orders from all tokens beside USDC, or all offerers besides one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related - https://linear.app/fulmin/issue/FLOOD-501/add-auth-to-frontend-and-trades-db