Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: devtools checks are repeated for push and pull request triggers #24

Closed
EagleoutIce opened this issue Sep 5, 2024 · 3 comments · Fixed by #25
Closed

CI: devtools checks are repeated for push and pull request triggers #24

EagleoutIce opened this issue Sep 5, 2024 · 3 comments · Fixed by #25
Assignees
@LukasPietzschmann
Labels
CI Addresses the CI

Comments

@EagleoutIce
Copy link
Member

This causes unnecessary re-runs. We should only run them once when someone pushes to a PR (e.g., by removing the push trigger if not on main?)

@LukasPietzschmann and @Ellpeck. What do you think?
@LukasPietzschmann
Copy link
Collaborator

Sounds reasonable to me

@EagleoutIce
Copy link
Member Author

Any of you want to do that? Otherwise I can do it later :)

@LukasPietzschmann
Copy link
Collaborator

Sure, I'll do it quickly

@LukasPietzschmann LukasPietzschmann self-assigned this Sep 5, 2024
@LukasPietzschmann LukasPietzschmann added the enhancement New feature or request label Sep 5, 2024
@LukasPietzschmann LukasPietzschmann linked a pull request Sep 5, 2024 that will close this issue
Only trigger the CI workflow for the main branch on push events #25
Merged
@LukasPietzschmann LukasPietzschmann added CI Addresses the CI and removed enhancement New feature or request labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasPietzschmann LukasPietzschmann

Labels
CI Addresses the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only trigger the CI workflow for the main branch on push events flowr-analysis/flowr-r-adapter
2 participants
@EagleoutIce @LukasPietzschmann