Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runix dev-shell #34

Closed
wants to merge 1 commit into from
Closed

fix: runix dev-shell #34

wants to merge 1 commit into from

Conversation

ysndr
Copy link
Contributor

@ysndr ysndr commented Jul 26, 2023

Develop runix using nix/flox develop .#rust-env

Closes #29

Develop runix using `nix/flox develop .#rust-env`
@ysndr ysndr requested review from zmitchell and mkenigs July 26, 2023 14:05
@ysndr
Copy link
Contributor Author

ysndr commented Jul 26, 2023

Uncovered another bug with arg ordering command that prevents us from using flox nix develop -c ...

@zmitchell
Copy link
Contributor

Why are we not using flox in CI anymore?

Copy link
Contributor

@zmitchell zmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't documented the "command order bug" you found somewhere you should do that so we know what's going wrong.

@@ -24,15 +24,17 @@ jobs:
with:
github-access-token: ${{ secrets.NIX_GIT_TOKEN }}

# - flox develop does not support non-interactive shells at the moment
# - flox commands have command order isssues, to be fixed here in runix
# and perculate to the install-flox-action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# and perculate to the install-flox-action
# and percolate to the install-flox-action

What are the command order issues?

@ysndr
Copy link
Contributor Author

ysndr commented Aug 3, 2023

I think this got mostly covered with #35

@ysndr ysndr closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-env flox environment is broken
2 participants