Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use parser-util as url parser #42

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: use parser-util as url parser #42

merged 1 commit into from
Aug 4, 2023

Conversation

zmitchell
Copy link
Contributor

@zmitchell zmitchell commented Aug 4, 2023 •
edited
Loading

This PR adds parser-util back in as the URL parser after its initial introduction in ef609b6 and it's temporary removal in 504e23f.

Necessary to close flox/flox#190

ysndr
ysndr approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@ysndr ysndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this just a revert of 504e23f?

@zmitchell
Copy link
Contributor Author

Correct

@zmitchell zmitchell merged commit 96145bd into main Aug 4, 2023
3 checks passed
@mkenigs mkenigs deleted the working-parser-util branch August 7, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysndr ysndr ysndr approved these changes

@aakropotkin aakropotkin Awaiting requested review from aakropotkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new URI parser
2 participants
@zmitchell @ysndr