Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): Refactor aqua #115

Merged
merged 11 commits into from
Oct 24, 2023
Merged

feat(gateway): Refactor aqua #115

merged 11 commits into from
Oct 24, 2023

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Oct 13, 2023 •
edited
Loading

  • Refactor aqua using new features introduced into the language
  • Separate code into files
  • Update README according to the new code
  • Update js-client to 0.3.0 (stage) for gateway

boneyard93501
boneyard93501 reviewed Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@boneyard93501 boneyard93501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.
any chance you can add an input check over the provided config file's mode string? right now a wrong input generates a rather non-descript error message.
what do you want to do with gateway/README.md?

gateway/aqua/rpc.aqua Outdated Show resolved Hide resolved
gateway/aqua/rpc.aqua Outdated Show resolved Hide resolved
@InversionSpaces InversionSpaces marked this pull request as ready for review October 24, 2023 10:05
@InversionSpaces InversionSpaces merged commit d608bf8 into main Oct 24, 2023
4 checks passed
@InversionSpaces InversionSpaces deleted the feat/refactor-aqua branch October 24, 2023 15:57
@fluencebot fluencebot mentioned this pull request Oct 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneyard93501 boneyard93501 boneyard93501 approved these changes

@alari alari Awaiting requested review from alari

@DieMyst DieMyst Awaiting requested review from DieMyst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InversionSpaces @boneyard93501